Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1245

Allow RelBuilder scan to take multiple arguments

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently Relbuilder.scan takes a single tableName string argument, however we'd like to use this to specify a sub-schema so we can use the Relbuilder to construct our queries across datasources.
      The idea would be to change "scan(String tableName)" to "scan(String… tableNames)", and add "scan(Iterable<String> tableNames)".

      This is as discussed here: http://mail-archives.apache.org/mod_mbox/calcite-dev/201605.mbox/%3CE4C0C38B-EDC2-4016-99C1-E7465AAC0C20%40apache.org%3E

      Opened this ticket so that we can submit a PR with the change.

        Activity

        Hide
        chris-baynes Chris Baynes added a comment -

        A PR has now been created for this: https://github.com/apache/calcite/pull/237

        Show
        chris-baynes Chris Baynes added a comment - A PR has now been created for this: https://github.com/apache/calcite/pull/237
        Hide
        julianhyde Julian Hyde added a comment -

        Thanks; I'll take a look.

        Show
        julianhyde Julian Hyde added a comment - Thanks; I'll take a look.
        Hide
        julianhyde Julian Hyde added a comment -

        Chris Baynes, Looks good. I made a few comments about cosmetics/comments; if you fix I will commit.

        Show
        julianhyde Julian Hyde added a comment - Chris Baynes , Looks good. I made a few comments about cosmetics/comments; if you fix I will commit.
        Hide
        chris-baynes Chris Baynes added a comment -

        Julian Hyde Have pushed again taking into account your suggestions, and squashed everything into a single commit (that seemed to me the way it has been done in other PRs).

        Show
        chris-baynes Chris Baynes added a comment - Julian Hyde Have pushed again taking into account your suggestions, and squashed everything into a single commit (that seemed to me the way it has been done in other PRs).
        Hide
        julianhyde Julian Hyde added a comment -
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/b76affcc . Thanks for the PR, Chris Baynes !
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.8.0 (2016-06-13).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.8.0 (2016-06-13).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            chris-baynes Chris Baynes
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development