Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1170

Allow SqlSetOperator to be overridden, as a regular SqlOperator can

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.8.0
    • core
    • None

    Description

      Calcite allows operators in SqlStdOperatorTable to be overridden when users would like to have their customized operators to be used instead. (see CALCITE-1062 as an example).

      If this logic is applied to SqlSetOperator, the systems which leverage Calcite can define their own output types (based on customized implicit casting rule) for Union-All, Intersect, etc.

      Below is more implementation-oriented:
      As is shown here [1], as opposed to calling deriveType(), the code calls validateOperands(). By doing so, the logic of overriding SqlOperator is skipped.

      However, if we call deriveType() here, the logic of overriding SqlOperator will happen and validateOperands() will be called right afterwards [2].

      [1] https://github.com/apache/calcite/blob/4c7f5c20a04b4a4e736a16f801d8b5e6eded48cc/core/src/main/java/org/apache/calcite/sql/validate/SetopNamespace.java#L105

      [2]
      https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/SqlOperator.java#L508

      Attachments

        Issue Links

          Activity

            People

              julianhyde Julian Hyde
              seanhychu Sean Hsuan-Yi Chu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: