[CALCITE-1054] NPE caused by wrong code generation for Timestamp fields

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6.0, 1.5.0, 1.4.0-incubating
• Fix Version/s: 1.16.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Frankie Bollaert
• Created: 13/Jan/16 08:52
• Updated: 27/Feb/24 22:23
• Resolved: 24/Jan/18 18:50

Description

Problem occurs when:

• Execute a query containing 2 checks on a Timestamp field
• Table contains records which have NULL values for this field

Example query:

select * from aTable where aTimestamp > timestamp '2015-1-1 00:00:00' and aTimestamp < timestamp '2015-2-1 00:00:00';

/*  48 */   public boolean moveNext() {
/*  49 */     while (inputEnumerator.moveNext()) {
/*  50 */       final java.sql.Timestamp inp23_ = (java.sql.Timestamp) ((Object[]) inputEnumerator.current())[23];
/*  51 */       final long v = org.apache.calcite.runtime.SqlFunctions.toLong(inp23_);
/*  52 */       if (inp23_ != null && v > 1420070400000L && (inp23_ != null && v < 1422748800000L)) {
/*  53 */         return true;
/*  54 */       }
/*  55 */     }
/*  56 */     return false;
/*  57 */   }

Stack trace snippet

Caused by: java.lang.NullPointerException
	at org.apache.calcite.runtime.SqlFunctions.toLong(SqlFunctions.java:1094)
	at org.apache.calcite.runtime.SqlFunctions.toLong(SqlFunctions.java:1089)
	at Baz$1$1.moveNext(ANONYMOUS.java:51)
	at org.apache.calcite.linq4j.Linq4j$EnumeratorIterator.<init>(Linq4j.java:677)
	at org.apache.calcite.linq4j.Linq4j.enumeratorIterator(Linq4j.java:103)

The generated code also looks wrong for date fields.

/*  15 */   public boolean moveNext() {
/*  16 */     while (inputEnumerator.moveNext()) {
/*  17 */       final java.sql.Date current = (java.sql.Date) inputEnumerator.current();
/*  18 */       final int v = org.apache.calcite.runtime.SqlFunctions.toInt(current);
/*  19 */       if (current != null && v > 2780 && (current != null && v < 5290)) {
/*  20 */         return true;
/*  21 */       }
/*  22 */     }
/*  23 */     return false;
/*  24 */   }

Other types of fields do not have this problem. Below is what the generated code looks like in the case of a String field. On line 20 there is a null check. This is the type of check that needs to be generated for Timestamp fields as well.

select empno from sales.emps where gender > 'A' and gender < 'Z';

/*  17 */  public boolean moveNext() {
/*  18 */    while (inputEnumerator.moveNext()) {
/*  19 */      final Object[] current = (Object[]) inputEnumerator.current();
/*  20 */      final String inp3_ = current[3] == null ? (String) null : current[3].toString();
/*  21 */      if (inp3_ != null && org.apache.calcite.runtime.SqlFunctions.gt(inp3_, $L4J$C$org_apache_calcite_runtime_SqlFunctions_rtrim_A_) && (inp3_ != null && org.apache.calcite.runtime.SqlFunctions.lt(inp3_, $L4J$C$org_apache_calcite_runtime_SqlFunctions_rtrim_Z_))) {
/*  22 */        return true;
/*  23 */      }
/*  24 */    }
/*  25 */    return false;
/*  26 */  }

Issue Links

• is depended upon by: CALCITE-1066 Add an extension operator table with Oracle-specific operators
• is duplicated by: CALCITE-1427 Code generation incorrect (does not compile) for DATE, TIME and TIMESTAMP fields
• relates to: CALCITE-1075 UDF Error of Calcite 1.6
• relates to: CALCITE-1102 Add implementations of built-in operators applied to ANY type
• relates to: CALCITE-1188 NullPointerException in EXTRACT with WHERE ... IN clause if field has null value
• relates to: CALCITE-1673 Query with ORDER BY or GROUP BY on TIMESTAMP column throws CompileException