Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1025

Add support for HTTP Basic auth (for proxies) in Avatica HTTP Client

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • avatica-1.8.0
    • avatica
    • None

    Description

      Avatica serves as the base for the Phoenix "thin" JDBC driver, and supports a JSON over HTTP protocol. Being that it is HTTP, it would be desirable to support standard HTTP mechanisms like HTTP BASIC authentication, which is required by some proxy servers (for example, Knox).

      In particular, I've been working on deploying Phoenix behind Knox with Knox mediating JDBC access using the "thin" driver based on Avatica. In order to make this work, I had to make a small change to Avatica in order to take the supplied credentials and construct an Authorization header, and add it to the HTTP request.

      I have made this change and verified that it works, and would like to propose merging it into the Avatica source. I have two versions, one made against HEAD and another which is a backport to an older version of Avatica (turns out this was needed for the specific environment we were deploying in).

      It is a fairly small change, totaling about 10-15 lines of code, and - as far as I can tell - should be totally non-invasive to existing users of Avatica. Basically I just add the HTTP Authorization header IF a username/password combo is present, and do nothing otherwise. If it is desired, we could also wrap this code in a parameter based on a query string parameter or something. Maybe "enableProxyAuth=true" or something along those lines.

      I'll attach the actual modified code shortly, but in the meantime wanted to start a discussion around this proposed change. I have run this by some people inside HortonWorks and they are in favor of implementing this so that it can become part of HDP. Being able to use Knox (or, in theory, any other proxy server) to mediate JDBC access to Phoenix seems to be a desirable thing. Thoughts?

      Attachments

        1. RemoteService.patch
          2 kB
          Phillip Rhodes
        2. patch_against_1.2.0.patch
          4 kB
          Phillip Rhodes
        3. http_auth_patch.patch
          6 kB
          Phillip Rhodes
        4. Driver.patch
          1 kB
          Phillip Rhodes
        5. AvaticaConnection.patch
          0.5 kB
          Phillip Rhodes

        Issue Links

          Activity

            People

              sprhodes Phillip Rhodes
              sprhodes Phillip Rhodes
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: