Cactus
  1. Cactus
  2. CACTUS-98

Why is there a requirement for ejb.manifest.classpath == true?

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6
    • Component/s: Maven Integration
    • Labels:
      None
    • Environment:
      Operating System: Other
      Platform: Other

      Description

      under <goal name="cactus:generate-ear-descriptor" prereqs="cactus:init">
      there is a check for <j:if test="$

      {dep.getProperty('ejb.manifest.classpath') =='true'}

      "> this seems to be causing problems when testing EARs.

      If I put in
      <ejb.manifest.classpath>true</> in the project.xml file for the modules it
      prevents deployment on jboss and if I remove it it does not add the module
      into jboss.

        Activity

        Hide
        Vincent Massol added a comment -

        Applied + added support for the new <ear.module> property tagging. Thanks!

        Show
        Vincent Massol added a comment - Applied + added support for the new <ear.module> property tagging. Thanks!
        Hide
        Vincent Massol added a comment -

        oops. Forget my previous comments. It's not correct. I was thinking about the
        <ant:ear> code but you're actually talking about the cactus:generate-ear-
        descriptor goal... Sorry. I'll have a look at this today and apply
        Emmanuel's patch.

        Show
        Vincent Massol added a comment - oops. Forget my previous comments. It's not correct. I was thinking about the <ant:ear> code but you're actually talking about the cactus:generate-ear- descriptor goal... Sorry. I'll have a look at this today and apply Emmanuel's patch.
        Hide
        Emmanuel Venisse added a comment -

        I think it's a correct patch.

        Emmanuel

        Index: integration/maven/plugin.jelly
        ===================================================================
        RCS file: /home/cvs/jakarta-cactus/integration/maven/plugin.jelly,v
        retrieving revision 1.22
        diff -r1.22 plugin.jelly
        1208c1208
        < <j:if test="$

        {dep.getProperty('ejb.manifest.classpath')=='true'}

        ">

        > <j:if test="$

        {dep.getProperty('ear.bundle')=='true' || dep.getProperty('ear.module')=='true'}

        ">

        Show
        Emmanuel Venisse added a comment - I think it's a correct patch. Emmanuel Index: integration/maven/plugin.jelly =================================================================== RCS file: /home/cvs/jakarta-cactus/integration/maven/plugin.jelly,v retrieving revision 1.22 diff -r1.22 plugin.jelly 1208c1208 < <j:if test="$ {dep.getProperty('ejb.manifest.classpath')=='true'} "> — > <j:if test="$ {dep.getProperty('ear.bundle')=='true' || dep.getProperty('ear.module')=='true'} ">
        Hide
        Vincent Massol added a comment -

        hmmm... I have just copied without thinking the <ear> behaviour found in the
        EAR plugin to the Cactus plugin.jelly... However, I've just seen that the EAR
        plugin has been recently updated and changed. So we should update the
        behaviour in cactus plugin.jelly to the new ear plugin.jelly. Got a patch?

        Show
        Vincent Massol added a comment - hmmm... I have just copied without thinking the <ear> behaviour found in the EAR plugin to the Cactus plugin.jelly... However, I've just seen that the EAR plugin has been recently updated and changed. So we should update the behaviour in cactus plugin.jelly to the new ear plugin.jelly. Got a patch?

          People

          • Assignee:
            Vincent Massol
            Reporter:
            Archimedes Trajano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development