I didn't knew about this container creation stuff ...
>What I do not like with this patch is that it'll be misleading because the
>default JBoss config is configured to use port 8080. Thus users will put
>cactus.port = whatever and it'll not work! They'll then report it as a bug...
What's the purpose of the cactus.port then? Whether you create the whole test
container or not, users may want it not to run on 8080 (because they have
already something else, like a tomcat running on their local copy). If you
provide this option, then either you let the user create its jboss container
itself, either you make sure that the container that will be automtically
created by the plugin uses the port specified by the user.
There's not much stuff to do to change the HTTP port (a simple grep -ri 8080 on
the deploy directory will give you two xml to change).
Also, this container creation seems weird to me. In our case, we have a lot of
custom libs and standard jar and war applications deployed in our test
container. If you plan to create it automatically, are you providing a way to
customize the created container somehow?