Cactus
  1. Cactus
  2. CACTUS-273

Build fails with checkstyle plugin 2.5

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.2
    • Component/s: Other
    • Labels:
      None

      Description

      This is related to CACTUS-262 but likely not the full story, hence this separate bug.

      When running a clean build of Cactus trunk you'll get version 2.5 of the checkstyle plugin (at least until 2.6 is released) and run into http://jira.codehaus.org/browse/MCHECKSTYLE-130

      At first I tried to fix the plugin version at 2.4 but the I'd need to change the checkstyle configuration since 2.4 usus checkstyle 5.0 and there have been some breaking changes "treewalker is not allowed as a parent of filelength" - see http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0

      Right now I'm running a build using version 2.3 and will provide a patch once it completes, I may also give version 2.4 and checkstyle 5.0 a try including the configuration changes necessary - or will add a comment if the changes look too big.

        Issue Links

          Activity

          Hide
          Stefan Bodewig added a comment -

          Trivial patch that fixes the plugin version at 2.3. Build passes using mvn 2.2.1 locally with this patch.

          Show
          Stefan Bodewig added a comment - Trivial patch that fixes the plugin version at 2.3. Build passes using mvn 2.2.1 locally with this patch.
          Hide
          Stefan Bodewig added a comment -

          This patch fixes the plugin version at 2.4 and adapts the configuration to checkstyle 5.x.

          I had to disable the JavadocType check since the @goal tags inside the Mojos are violations now and the allowUnknownTags property doesn't seem to work with the 2.4 plugin.

          If I were to decide I'd apply this patch and not the earlier one since it is going to help once the 2.6 version of the checkstyle plugin becomes available as well (and it would help Gump more

          Show
          Stefan Bodewig added a comment - This patch fixes the plugin version at 2.4 and adapts the configuration to checkstyle 5.x. I had to disable the JavadocType check since the @goal tags inside the Mojos are violations now and the allowUnknownTags property doesn't seem to work with the 2.4 plugin. If I were to decide I'd apply this patch and not the earlier one since it is going to help once the 2.6 version of the checkstyle plugin becomes available as well (and it would help Gump more
          Hide
          Stefan Bodewig added a comment -

          svn revision 979968

          Show
          Stefan Bodewig added a comment - svn revision 979968

            People

            • Assignee:
              Unassigned
              Reporter:
              Stefan Bodewig
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development