BVal
  1. BVal
  2. BVAL-52

ValidationParser.getInputStream() should call getResourceAsStream() for TCK suite to work

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1-incubating
    • Fix Version/s: 0.1-incubating
    • Component/s: jsr303
    • Labels:
      None

      Description

      Not really a bug here (current implementation is fine), but when running standalone, the TCK overloads the classloader with a custom one that overrides getResourceAsStream but does not give functionality to getResources().

      I changed our getInputStream() impl to work properly under the TCK while keeping the same functionality.

      Good news is 10 more TCK tests pass in standalone mode

        Activity

        Hide
        Carlos Vara added a comment -

        Patch.

        Show
        Carlos Vara added a comment - Patch.
        Hide
        Carlos Vara added a comment -

        Upgraded patch:

        • For additional resource files referred inside XML files, starting "/" char is removed, as the classloader fails with an absolute path. This one was a bug AFAIK.

        10 more standalone tests pass, only 10 to go.

        Show
        Carlos Vara added a comment - Upgraded patch: For additional resource files referred inside XML files, starting "/" char is removed, as the classloader fails with an absolute path. This one was a bug AFAIK. 10 more standalone tests pass, only 10 to go.
        Hide
        Donald Woods added a comment -

        Committed revision 946678.
        Stand-alone tck results -
        Tests run: 244, Failures: 10, Errors: 0, Skipped: 0
        In-container tck results -
        Tests run: 258, Failures: 11, Errors: 0, Skipped: 0

        Show
        Donald Woods added a comment - Committed revision 946678. Stand-alone tck results - Tests run: 244, Failures: 10, Errors: 0, Skipped: 0 In-container tck results - Tests run: 258, Failures: 11, Errors: 0, Skipped: 0
        Hide
        Matt Benson added a comment -

        closing issues associated with existing releases

        Show
        Matt Benson added a comment - closing issues associated with existing releases

          People

          • Assignee:
            Donald Woods
            Reporter:
            Carlos Vara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development