BVal
  1. BVal
  2. BVAL-25

When validating a bean whose getter throws a RTE, it must be wrapped in a ValidationException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1-incubating
    • Fix Version/s: 0.2-incubating
    • Component/s: jsr303
    • Labels:
      None

      Description

      To fix this, I did some cleaning in the way exceptions are handled

      • Created UnknownPropertyException, which extends ValidationException, to easily route that case and translate it to an IllegalArgumentException at top level method exit.
      • All RTE thrown by getters in the validated beans will be wrapped in a ValidationException.
      • Changed method unrecoverableValidationError(..) to build exceptions instead of throwing them.
      • Created a set of tests that verify that the methods in ClassValidator honor the exception contract in the spec.

      3 more tests pass.

      1. ExceptionHandling.patch
        2 kB
        Carlos Vara
      2. ExceptionsContractTest.java
        7 kB
        Carlos Vara
      3. UnknownPropertyException.java
        1 kB
        Carlos Vara

        Activity

        Hide
        Roman Stumm added a comment -

        Fixes applied, good job (as usual). Thanks, Carlos!

        Show
        Roman Stumm added a comment - Fixes applied, good job (as usual). Thanks, Carlos!
        Hide
        Carlos Vara added a comment -

        Fix and new classes attached.

        Show
        Carlos Vara added a comment - Fix and new classes attached.

          People

          • Assignee:
            Roman Stumm
            Reporter:
            Carlos Vara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development