[BUILDR-399] invoke_with_call_chain does not restore call chain correctly

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.5
• Fix Version/s: 1.4
• Component/s: Core features
• Assignee: Unassigned
• Reporter: Pepijn Van Eeckhoudt
• Created: 15/Mar/10 22:05
• Updated: 22/Jun/11 10:10
• Resolved: 15/Mar/10 22:29

Description

invoke_with_call_chain currently does

begin
old_chain, Thread.current[:rake_chain] = Thread.current[:rake_chain], new_chain
execute(task_args) if needed?
ensure
Thread.current[:rake_chain] = nil
end

The ensure block restores the call chain incorrectly. The call chain should be restored to old_chain rather than nil.

Attached spec reproduces the issue.