Uploaded image for project: 'Buildr (Retired)'
  1. Buildr (Retired)
  2. BUILDR-399

invoke_with_call_chain does not restore call chain correctly

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.3.5
    • 1.4
    • Core features
    • None

    Description

      invoke_with_call_chain currently does

      begin
      old_chain, Thread.current[:rake_chain] = Thread.current[:rake_chain], new_chain
      execute(task_args) if needed?
      ensure
      Thread.current[:rake_chain] = nil
      end

      The ensure block restores the call chain incorrectly. The call chain should be restored to old_chain rather than nil.

      Attached spec reproduces the issue.

      Attachments

        1. spec.txt
          0.3 kB
          Pepijn Van Eeckhoudt

        Activity

          People

            Unassigned Unassigned
            pepijnve Pepijn Van Eeckhoudt
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: