[BUILDR-247] JtestR test framework does not pass configured system properties to runner (Cause: OpenObject does not work with Hash#only)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.3
• Fix Version/s: 1.3.4
• Component/s: Core features, Test frameworks
• Environment: Ruby 1.8.6.
• Assignee: Unassigned
• Reporter: Rhett Sutphin
• Created: 10/Feb/09 04:13
• Updated: 22/Jun/11 10:10
• Resolved: 12/Mar/09 23:14

Description

Properties configured with test.using(:jtestr, :properties =>

{ ... }

) are not actually passed to the tests when they run.

Digging into the cause, it appears to come from Buildr::TestFramework::JRubyBased#run, so rspec testing is probably also affected. The root cause is that Hash#only doesn't work if the hash is an OpenObject. Here's a spec that fails:

describe "Hash#only" do
it "works with OpenObjects" do
OpenObject.new({:a => 1, :b => 2, :c => 3}).only(:a).should == { :a => 1 }
end
end

The result of only(:a) is actually an empty hash because OpenObject doesn't delegate has_key? to @hash. It seems like OpenObject either needs to delegate all of Hash's methods to it's internal @hash or it needs to get rid of it.