Uploaded image for project: 'Buildr (Retired)'
  1. Buildr (Retired)
  2. BUILDR-218

Manifest.from_zip fails if the zip doesn't already have META-INF/MANIFEST.MF

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3.4
    • Packaging
    • None

    Description

      in java/packaging.rb:
      def from_zip(file)
      Zip::ZipFile.open(file.to_s) do |zip|
      return Manifest.new unless zip.get_entry('META-INF/MANIFEST.MF')
      Manifest.parse zip.read('META-INF/MANIFEST.MF')
      end
      end

      zip.get_entry fails with an exception if the entry doesn't exist, so the whole method fails

      Attachments

        1. 02_patch_for_manifest_bug.patch
          0.7 kB
          Joel Muzzerall
        2. 01_spec_for_manifest_bug.patch
          0.7 kB
          Joel Muzzerall

        Activity

          People

            Unassigned Unassigned
            ittayd Ittay Dror
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: