[BUILDR-199] ArchiveTask#needed uses 'each' with no effect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.4
• Fix Version/s: 1.3.4
• Assignee: Unassigned
• Reporter: Ittay Dror
• Created: 03/Nov/08 16:17
• Updated: 22/Jun/11 10:09
• Resolved: 06/Nov/08 20:23

Description

this is some of the code of the method:

most_recent = @paths.collect

{ |name, path| path.sources }

.flatten

each

{ |src| File.directory?(src) ? Util.recursive_with_dot_files(src) | [src] : src }

.flatten.
select

{ |file| File.exist?(file) }

.collect

{ |file| File.stat(file).mtime }

.max
File.stat(name).mtime < (most_recent || Rake::EARLY) || super

the 'each' call effectively a noop (being that each just returns the same array)