Buildr
  1. Buildr
  2. BUILDR-117

Shared directory for both code and resources produces duplicate Eclipse classpath entries

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.2, 1.3.3
    • Fix Version/s: 1.3.3
    • Component/s: IDE
    • Labels:
      None

      Description

      I usually use

      resources.from('src/main/java').exclude('*/.java')

      to include resources from the java compilation directory, but this causes the eclipse task to produce a two identical entries for that directory and Eclipse gets all confused until you delete the duplicate. I've got a patch, just a sec!

        Issue Links

          Activity

          Hide
          Nathan Hamblen added a comment -

          Combines the source dirs before checking uniqueness and also checks all for existence instead of just resources.

          Show
          Nathan Hamblen added a comment - Combines the source dirs before checking uniqueness and also checks all for existence instead of just resources.
          Hide
          Alex Boisvert added a comment -

          Patch applied. Thanks!

          svn commit -m "BUILDR-117: Shared directory for both code and resources produces duplicate Eclipse classpath entries"
          Sending buildr/ide/eclipse.rb
          Transmitting file data .
          Committed revision 682463.

          Show
          Alex Boisvert added a comment - Patch applied. Thanks! svn commit -m " BUILDR-117 : Shared directory for both code and resources produces duplicate Eclipse classpath entries" Sending buildr/ide/eclipse.rb Transmitting file data . Committed revision 682463.
          Hide
          Alex Boisvert added a comment -

          Turns out this patch breaks the new specs submitted in BUILDR-119. Reopening for review.

          Show
          Alex Boisvert added a comment - Turns out this patch breaks the new specs submitted in BUILDR-119 . Reopening for review.
          Hide
          Nathan Hamblen added a comment -

          Yeah that test is failing because the user defined path 'src/java' does not exist. If you add

          write 'src/java/Other.java'

          to the before it will pass. But what is the correct behavior? Should only resources be checked for existence? Should nothing be checked for existence? 'src/main/resource' doesn't get added in the first place unless it exists, but that may have been different when this eclipse exporter was first written.

          Show
          Nathan Hamblen added a comment - Yeah that test is failing because the user defined path 'src/java' does not exist. If you add write 'src/java/Other.java' to the before it will pass. But what is the correct behavior? Should only resources be checked for existence? Should nothing be checked for existence? 'src/main/resource' doesn't get added in the first place unless it exists, but that may have been different when this eclipse exporter was first written.
          Hide
          Alex Boisvert added a comment -

          Thanks for the explanation. I'm marking as resolved now since the was patch already applied.

          We can discuss the source directory existence over at BUILDR-122, which is a more specific issue.

          Show
          Alex Boisvert added a comment - Thanks for the explanation. I'm marking as resolved now since the was patch already applied. We can discuss the source directory existence over at BUILDR-122 , which is a more specific issue.

            People

            • Assignee:
              Alex Boisvert
              Reporter:
              Nathan Hamblen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development