[BROOKLYN-291] Manually setting service.isUp is overwritten by enricher (causing non-deterministic test failures) - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 0.9.0
Fix Version/s: 0.10.0
Labels:
None

Description

If one creates an entity and explicitly sets its service.isUp to true, then the default enrichers can override this value to remove it. This is because it is executing concurrently, and if service-up-indicators is null then it removes the service.isUp sensor value!

A similar thing happens for the service.state sensor.

This is non-deterministic, but can be demonstrate with this simple test:

for (int i = 0; i < 100; i++) {
    TestEntity entity = app.addChild(EntitySpec.create(TestEntity.class));
    entity.sensors().set(TestEntity.SERVICE_UP, true);
    entity.sensors().set(TestEntity.SERVICE_STATE_ACTUAL, Lifecycle.RUNNING);
    Thread.sleep(10);
    assertEquals(entity.sensors().get(TestEntity.SERVICE_UP), Boolean.TRUE);
    assertEquals(entity.sensors().get(TestEntity.SERVICE_STATE_ACTUAL), Lifecycle.RUNNING);
}

Most entities don't explicitly set the service.isUp, so it has not been a problem in production systems. However, it does impact tests - it is the likely cause of many non-deterministic test failures.