[BOOKKEEPER-966] change the bookieServer cmdline to make conf-file and option co-exist

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.5.0
• Assignee: Jia Zhai
• Reporter: Jia Zhai
• Created: 09/Nov/16 07:43
• Updated: 27/May/17 16:20
• Resolved: 17/Dec/16 01:45

Description

Currently, when using bookieServer cmdline to start a bookie, you will either give it a cofiguration file by "-c booke.conf"; or add some options like "<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix sequential.
It may not satisfy some of the requirement. So changed it to be co-exist for configuration file and options.

By this change, it will first use settings in configuration file; and then use options to overwrite some of the settings, if there are some options provided.

Here is an example after this change:
BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p 3181 -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
Here, in this command:
-z is for “Zookeeper client instance”;
-m is for "Zookeeper ledgers root path for bookies";
-p is for "bookie service port exported";
-j is for "bookie journal directory";
-l is for "bookie ledgers directories".

Issue Links

• is related to: BOOKKEEPER-1081 Would like to provide a docker file for bookkeeper
• relates to: BOOKKEEPER-985 change the bookieServer cmdline to pass any configuration property and system properties
• links to: GitHub Pull Request #75