[BOOKKEEPER-958] ZeroBuffer readOnlyBuffer returns ByteBuffer with 0 remaining bytes for length > 64k

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 4.5.0
• Assignee: Charan Reddy Guttapalem
• Reporter: Charan Reddy Guttapalem
• Created: 19/Oct/16 23:23
• Updated: 09/Nov/16 13:13
• Resolved: 09/Nov/16 07:49

Description

in ZeroBuffer
here, if the length is > zeroBytes.length (64K), then it is returning zero ByteBuffer but its position is set to limit and hence its remaining will be 0, which is not expected, but if it is < 64k then its position is set to 0 and the remaining will be length.

Looking at the call hierearchy, it seems there are no callers for this function, but since this is utility class it needs to be corrected.

public static ByteBuffer readOnlyBuffer(int length) {
ByteBuffer buffer;
if (length <= zeroBytes.length)

{ buffer = ByteBuffer.wrap(zeroBytes, 0, length); }

else

{ buffer = ByteBuffer.allocate(length); put(buffer); }

return buffer.asReadOnlyBuffer();
}

Issue Links

• links to: GitHub Pull Request #66