Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-89

Bookkeeper API changes for initial Bookkeeper release

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0
    • None
    • None

    Description

      Changes are as follows.

      BookKeeper#createLedger, parameter is named passwd, "Key" used in LedgerHandle api
      BookKeeper#getBookieClient shouldn't be public
      BookKeeper#createComplete shouldn't be public
      BookKeeper#openComplete shouldn't be public
      BookKeeper#deleteComplete shouldn't be public
      BookKeeper#halt could be changed to close(), should throw a BKException

      LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private
      LedgerHandle#getLedgerMetadata shouldn't be public
      LedgerHandle#getDigestManager shouldn't be public
      LedgerHandle#getDistributionSchedule shouldn't be public
      LedgerHandle#writeLedgerConfig shouldn't be public
      LedgerHandle#addEntry should return void, errors should go in an Exception
      LedgerHandle#readComplete should not be public
      LedgerHandle#addComplete should not be public
      LedgerHandle#readLastConfirmedCompelte should not be public
      LedgerHandle#closeComplete should not be public

      ASyncCallback#RecoverCallback shouldn't be public

      Attachments

        1. BOOKKEEPER-89.diff
          112 kB
          Ivan Kelly
        2. BOOKKEEPER-89.diff
          111 kB
          Ivan Kelly
        3. BOOKKEEPER-89.diff
          111 kB
          Ivan Kelly
        4. BOOKKEEPER-89.diff
          117 kB
          Ivan Kelly
        5. BOOKKEEPER-89.diff
          105 kB
          Ivan Kelly
        6. TEST-org.apache.bookkeeper.test.BookieReadWriteTest.xml
          11 kB
          Flavio Paiva Junqueira

        Activity

          People

            ikelly Ivan Kelly
            ikelly Ivan Kelly
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: