Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Fix warnings issued by FindBugs

      1. BOOKKEEPER-72.diff
        59 kB
        Ivan Kelly
      2. BOOKKEEPER-72.diff
        57 kB
        Ivan Kelly
      3. findbugsXml.xml
        144 kB
        Ivan Kelly
      4. findbugsXml.xml
        51 kB
        Ivan Kelly
      5. findbugsXml.xml
        78 kB
        Ivan Kelly
      6. findbugsXml.xml
        176 kB
        Ivan Kelly
      7. findbugsXml.xml
        36 kB
        Ivan Kelly

        Activity

        Hide
        Ivan Kelly added a comment -

        Attached warnings.

        Show
        Ivan Kelly added a comment - Attached warnings.
        Hide
        Ivan Kelly added a comment -

        There's too many warning to fix before this release. Making a blocker for 4.1.0.

        Show
        Ivan Kelly added a comment - There's too many warning to fix before this release. Making a blocker for 4.1.0.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Ivan,
        Lets split the work based on bug category. As bug count is 54 currently. Some might have addressed already.

        Also my suggestion is to add exclude filter file to add any invalid bugs into it.

        Show
        Uma Maheswara Rao G added a comment - Hi Ivan, Lets split the work based on bug category. As bug count is 54 currently. Some might have addressed already. Also my suggestion is to add exclude filter file to add any invalid bugs into it.
        Hide
        Ivan Kelly added a comment -

        Actually, I have most of it done. I have about 36 more to do in hedwig-server. hedwig-protocol & hedwig-client are done (both were tiny). There's already a patch available to bookkeeper-server. bookkeeper-benchmark is still untouched if you want to look at that.

        Show
        Ivan Kelly added a comment - Actually, I have most of it done. I have about 36 more to do in hedwig-server. hedwig-protocol & hedwig-client are done (both were tiny). There's already a patch available to bookkeeper-server. bookkeeper-benchmark is still untouched if you want to look at that.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Ivan, for the deatils. I just filed a bug BOOKKEEPER-228 for BK Bench. You can assign that issue to me. I will take care of it.

        Show
        Uma Maheswara Rao G added a comment - Thanks Ivan, for the deatils. I just filed a bug BOOKKEEPER-228 for BK Bench. You can assign that issue to me. I will take care of it.
        Hide
        Ivan Kelly added a comment -

        I can't find your name on the assignee list :/ I'll ask the infra guys.

        Show
        Ivan Kelly added a comment - I can't find your name on the assignee list :/ I'll ask the infra guys.
        Hide
        Flavio Junqueira added a comment -

        I have added Uma to the contributors list.

        Show
        Flavio Junqueira added a comment - I have added Uma to the contributors list.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot Flavio and Ivan.

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot Flavio and Ivan.
        Hide
        Ivan Kelly added a comment -

        This patch fixes the findbugs in hedwig-*.

        Show
        Ivan Kelly added a comment - This patch fixes the findbugs in hedwig-*.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5051/
        -----------------------------------------------------------

        Review request for bookkeeper.

        Summary
        -------

        This patch is for the hedwig components of Bookkeeper.

        This addresses bug BOOKKEEPER-72.
        https://issues.apache.org/jira/browse/BOOKKEEPER-72

        Diffs


        hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af
        hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9
        hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3
        hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368
        hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a
        hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c
        hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e
        hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5
        hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4
        hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16
        hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e
        hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057
        hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544
        hedwig-server/pom.xml 12c8eba
        hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8
        hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb
        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0
        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5
        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8
        hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705
        hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4
        hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e
        hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6d91167
        hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43
        hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363
        hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2
        hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d
        hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c
        hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e

        Diff: https://reviews.apache.org/r/5051/diff

        Testing
        -------

        Thanks,

        Ivan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5051/ ----------------------------------------------------------- Review request for bookkeeper. Summary ------- This patch is for the hedwig components of Bookkeeper. This addresses bug BOOKKEEPER-72 . https://issues.apache.org/jira/browse/BOOKKEEPER-72 Diffs hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9 hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3 hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368 hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5 hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7 hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4 hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922 hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16 hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057 hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544 hedwig-server/pom.xml 12c8eba hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8 hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0 hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5 hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8 hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705 hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4 hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6d91167 hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43 hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363 hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2 hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e Diff: https://reviews.apache.org/r/5051/diff Testing ------- Thanks, Ivan
        Hide
        Ivan Kelly added a comment -

        New patch. rebased to trunk and added findbugs exclude for findbugs for localdb persistence manager. This findbug cannot be fixed as there's no way to use an SQL parameter for a table in a query. I hash the topic to about SQL injections.

        Show
        Ivan Kelly added a comment - New patch. rebased to trunk and added findbugs exclude for findbugs for localdb persistence manager. This findbug cannot be fixed as there's no way to use an SQL parameter for a table in a query. I hash the topic to about SQL injections.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5051/
        -----------------------------------------------------------

        (Updated 2012-05-10 12:59:25.008772)

        Review request for bookkeeper.

        Changes
        -------

        Added findbugsExclude.xml

        Summary
        -------

        This patch is for the hedwig components of Bookkeeper.

        This addresses bug BOOKKEEPER-72.
        https://issues.apache.org/jira/browse/BOOKKEEPER-72

        Diffs (updated)


        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5
        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8
        hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0
        hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb
        hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e
        hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057
        hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544
        hedwig-server/pom.xml c7e41c9
        hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16
        hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4
        hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43
        hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c
        hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e
        hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5
        hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7
        hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593
        hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368
        hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a
        hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9
        hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3
        hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af
        hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705
        hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4
        hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e
        hedwig-server/src/main/resources/findbugsExclude.xml PRE-CREATION
        hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6b2e731
        hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43
        hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363
        hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2
        hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d
        hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c
        hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e

        Diff: https://reviews.apache.org/r/5051/diff

        Testing
        -------

        Thanks,

        Ivan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5051/ ----------------------------------------------------------- (Updated 2012-05-10 12:59:25.008772) Review request for bookkeeper. Changes ------- Added findbugsExclude.xml Summary ------- This patch is for the hedwig components of Bookkeeper. This addresses bug BOOKKEEPER-72 . https://issues.apache.org/jira/browse/BOOKKEEPER-72 Diffs (updated) hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5 hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8 hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0 hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057 hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544 hedwig-server/pom.xml c7e41c9 hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8 hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16 hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4 hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43 hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5 hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7 hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593 hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368 hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9 hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3 hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705 hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4 hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e hedwig-server/src/main/resources/findbugsExclude.xml PRE-CREATION hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6b2e731 hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43 hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363 hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2 hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e Diff: https://reviews.apache.org/r/5051/diff Testing ------- Thanks, Ivan
        Hide
        Sijie Guo added a comment -

        the patch looks good to me. +1

        Show
        Sijie Guo added a comment - the patch looks good to me. +1
        Hide
        Ivan Kelly added a comment -

        Committed r1339691, Thanks for reviewing Sijie

        Show
        Ivan Kelly added a comment - Committed r1339691, Thanks for reviewing Sijie
        Hide
        Hudson added a comment -

        Integrated in bookkeeper-trunk #515 (See https://builds.apache.org/job/bookkeeper-trunk/515/)
        BOOKKEEPER-72: Fix warnings issued by FindBugs (ivank) (Revision 1339691)

        Result = SUCCESS
        ivank :
        Files :

        • /zookeeper/bookkeeper/trunk/CHANGES.txt
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java
        • /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/pom.xml
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/resources/findbugsExclude.xml
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java
        Show
        Hudson added a comment - Integrated in bookkeeper-trunk #515 (See https://builds.apache.org/job/bookkeeper-trunk/515/ ) BOOKKEEPER-72 : Fix warnings issued by FindBugs (ivank) (Revision 1339691) Result = SUCCESS ivank : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java /zookeeper/bookkeeper/trunk/hedwig-server/pom.xml /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/resources/findbugsExclude.xml /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development