Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-605

Use static Logger objects everywhere for bookkeeper

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 4.3.0
    • None
    • None

    Description

      There are some classes where the SLF4J Logger is not declared as static. Some of them are classes that will have many instances LedgerEntry, PendingReadOp :

      $ git grep LoggerFactory.getLogger | grep -v static
      bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java:    Logger LOG = LoggerFactory.getLogger(LedgerEntry.class);
      bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java:    Logger LOG = LoggerFactory.getLogger(PendingReadOp.class);
      bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java:    Logger LOG = LoggerFactory.getLogger(NIOServerFactory.class);
      bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java:    Logger LOG = LoggerFactory.getLogger(LedgerInputStream.class);
      bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java:    Logger LOG = LoggerFactory.getLogger(LedgerOutputStream.class);
      bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java:    Logger LOG = LoggerFactory.getLogger(LoopbackClient.class);
      hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java:    Logger logger = LoggerFactory.getLogger(ClientConfiguration.class);
      hedwig-client/src/main/java/org/apache/hedwig/client/handlers/CloseSubscriptionResponseHandler.java:        LoggerFactory.getLogger(CloseSubscriptionResponseHandler.class);
      hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/AbstractSubscribeResponseHandler.java:        LoggerFactory.getLogger(AbstractSubscribeResponseHandler.class);
      hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/MultiplexSubscribeResponseHandler.java:        LoggerFactory.getLogger(MultiplexSubscribeResponseHandler.class);
      hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookkeeperPersistenceManagerWhiteBox.java:        LoggerFactory.getLogger(TestBookkeeperPersistenceManagerWhiteBox.class);
      

      Attachments

        1. BOOKKEEPER-605.patch
          50 kB
          Sijie Guo
        2. BOOKKEEPER-605.diff
          3 kB
          Matteo Merli
        3. BOOKKEEPER-605.diff
          46 kB
          Matteo Merli

        Issue Links

          Activity

            People

              mmerli Matteo Merli
              mmerli Matteo Merli
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: