Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-569

Critical performance bug in InterleavedLedgerStorage

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      There's a synchronization on InterleavedLedgerStorage#flush(), which kills performance when you're writing to many ledgers on a single bookie. Both #flush and #addEntry are synchronized, which blocks any adds being serviced while the sync thread is running.

      The sync on #addEntry has always been there, but on #flush it has only existed since BOOKKEEPER-293. The addition was obviously a mistake.

      Fix is simply to remove it.

        Activity

        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ivan Kelly made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ivan Kelly made changes -
        Field Original Value New Value
        Attachment 0001-BOOKKEEPER-569-Critical-performance-issue-in-Interle.patch [ 12569224 ]
        Ivan Kelly created issue -

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development