Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-556

BookieServerMXBean#getServerState makes no sense

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.2, 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      This got carried over from zookeeper during a copy paste. In ZooKeeper it's used to specify whether a server is standalone or not. This isn't relevant for BookKeeper.

        Issue Links

          Activity

          Hide
          Ivan Kelly added a comment -

          Removed getServerState and more unused junk from the class.

          Show
          Ivan Kelly added a comment - Removed getServerState and more unused junk from the class.
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-556

          Patch 0001-BOOKKEEPER-556-BookieServerMXBean-getServerState-mak.patch downloaded at Thu Jan 24 17:20:42 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          -1 FINDBUGS
          . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server]
          +1 TESTS
          . Tests run: 790
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/252/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-556 Patch 0001-BOOKKEEPER-556-BookieServerMXBean-getServerState-mak.patch downloaded at Thu Jan 24 17:20:42 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FINDBUGS . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server] +1 TESTS . Tests run: 790 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/252/
          Hide
          Ivan Kelly added a comment -

          Fix findbug. There was one variable that was unused after the cleanup.

          Show
          Ivan Kelly added a comment - Fix findbug. There was one variable that was unused after the cleanup.
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-556

          Patch 0001-BOOKKEEPER-556-BookieServerMXBean-getServerState-mak.patch downloaded at Thu Jan 24 19:12:57 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 790
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/254/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-556 Patch 0001-BOOKKEEPER-556-BookieServerMXBean-getServerState-mak.patch downloaded at Thu Jan 24 19:12:57 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 790 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/254/
          Hide
          Sijie Guo added a comment -

          lgtm +1.

          Show
          Sijie Guo added a comment - lgtm +1.
          Hide
          Sijie Guo added a comment -

          committed as r1444340. thanks Ivan.

          Show
          Sijie Guo added a comment - committed as r1444340. thanks Ivan.
          Hide
          Hudson added a comment -

          Integrated in bookkeeper-trunk #94 (See https://builds.apache.org/job/bookkeeper-trunk/94/)
          BOOKKEEPER-556: BookieServerMXBean#getServerState makes no sense (ivank via sijie) (Revision 1444340)

          Result = SUCCESS
          sijie :
          Files :

          • /zookeeper/bookkeeper/trunk/CHANGES.txt
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerMXBean.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ServerStats.java
          Show
          Hudson added a comment - Integrated in bookkeeper-trunk #94 (See https://builds.apache.org/job/bookkeeper-trunk/94/ ) BOOKKEEPER-556 : BookieServerMXBean#getServerState makes no sense (ivank via sijie) (Revision 1444340) Result = SUCCESS sijie : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerMXBean.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ServerStats.java
          Hide
          Ivan Kelly added a comment -

          Committed revision 1490376, to 4.2 branch

          Show
          Ivan Kelly added a comment - Committed revision 1490376, to 4.2 branch

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development