Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Move from the custom NIO server to netty. This will make it easier to do things like add more server side threads and support SSL.

        Issue Links

          Activity

          Ivan Kelly created issue -
          Hide
          Ivan Kelly added a comment -

          First cut at the patch. I need to get tests back up to 100% and run some benchmarks to ensure performance isn't taking a hit.

          Show
          Ivan Kelly added a comment - First cut at the patch. I need to get tests back up to 100% and run some benchmarks to ensure performance isn't taking a hit.
          Ivan Kelly made changes -
          Field Original Value New Value
          Attachment 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch [ 12566330 ]
          Ivan Kelly made changes -
          Link This issue depends on BOOKKEEPER-556 [ BOOKKEEPER-556 ]
          Hide
          Ivan Kelly added a comment -

          Patch is code complete, and should be passing all tests 100%. I have yet to benchmark.

          Show
          Ivan Kelly added a comment - Patch is code complete, and should be passing all tests 100%. I have yet to benchmark.
          Ivan Kelly made changes -
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-555

          Patch 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Tue Jan 29 18:50:40 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . -1 patch does not compile
          . +1 the patch does not seem to introduce new javac warnings
          -1 FINDBUGS
          . -1 the patch seems to introduce 2 new Findbugs warning(s) in module(s) [bookkeeper-server]
          -1 TESTS - patch does not compile, cannot run testcases
          -1 DISTRO
          . -1 distro tarball fails with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/257/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-555 Patch 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Tue Jan 29 18:50:40 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings -1 FINDBUGS . -1 the patch seems to introduce 2 new Findbugs warning(s) in module(s) [bookkeeper-server] -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/257/
          Hide
          Ivan Kelly added a comment -

          I've benchmarked a single bookie with and without the netty server, using bookkeeper-benchmark/bin/benchmark bookie. I ran each 5 times.

            Throughput Stddev Latency Stddev
          netty 22988.4 1656.9 1.5 0.1
          no netty 20785.6 1220.4 1.5 0.1

          So netty even gives a slight improvement. Therefore, I think this change it ready to go.

          The precommit failure is due to the fact that BOOKKEEPER-556 is required. I'll kick it off again once BOOKKEEPER-556 is in.

          Show
          Ivan Kelly added a comment - I've benchmarked a single bookie with and without the netty server, using bookkeeper-benchmark/bin/benchmark bookie. I ran each 5 times.   Throughput Stddev Latency Stddev netty 22988.4 1656.9 1.5 0.1 no netty 20785.6 1220.4 1.5 0.1 So netty even gives a slight improvement. Therefore, I think this change it ready to go. The precommit failure is due to the fact that BOOKKEEPER-556 is required. I'll kick it off again once BOOKKEEPER-556 is in.
          Hide
          Flavio Junqueira added a comment -

          +1, it looks great, Ivan. It also only worked after applying BOOKKEEPER-556, it would be good to commit them both together.

          If no one else expresses a concern with this patch, I'll commit it along with BOOKKEEPER-556.

          Show
          Flavio Junqueira added a comment - +1, it looks great, Ivan. It also only worked after applying BOOKKEEPER-556 , it would be good to commit them both together. If no one else expresses a concern with this patch, I'll commit it along with BOOKKEEPER-556 .
          Hide
          Sijie Guo added a comment -

          I haven't go through the details on this patch. but just one comment about ChannelGroup. There is a known race condition when shutdown a channel group and adding a opened channel into channel group. if a channel added after closed, ChannelGroup doesn't take the responsibility of closing it. Then netty would hang. This issue would exist in Hedwig server too, but it is fine for Hedwig server, since there is no shutdown hook. But it might be bad for bookie server, since there is a shutdown hook. A bookie might hang on shutting down. It would better to extend DefaultChannelGroup to provide a cleanup feature, like CleanupChannelMap in hedwig client.

          similar solution in async-http-client: http://asynchttpclient.github.com/async-http-client/apidocs/com/ning/http/util/CleanupChannelGroup.html

          Show
          Sijie Guo added a comment - I haven't go through the details on this patch. but just one comment about ChannelGroup. There is a known race condition when shutdown a channel group and adding a opened channel into channel group. if a channel added after closed, ChannelGroup doesn't take the responsibility of closing it. Then netty would hang. This issue would exist in Hedwig server too, but it is fine for Hedwig server, since there is no shutdown hook. But it might be bad for bookie server, since there is a shutdown hook. A bookie might hang on shutting down. It would better to extend DefaultChannelGroup to provide a cleanup feature, like CleanupChannelMap in hedwig client. similar solution in async-http-client: http://asynchttpclient.github.com/async-http-client/apidocs/com/ning/http/util/CleanupChannelGroup.html
          Hide
          Ivan Kelly added a comment - - edited

          Added cleanup channel group.

          Show
          Ivan Kelly added a comment - - edited Added cleanup channel group.
          Ivan Kelly made changes -
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-555

          Patch 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Tue Feb 5 18:41:32 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . -1 patch does not compile
          . +1 the patch does not seem to introduce new javac warnings
          -1 FINDBUGS
          . -1 the patch seems to introduce 3 new Findbugs warning(s) in module(s) [bookkeeper-server]
          -1 TESTS - patch does not compile, cannot run testcases
          -1 DISTRO
          . -1 distro tarball fails with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/260/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-555 Patch 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Tue Feb 5 18:41:32 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings -1 FINDBUGS . -1 the patch seems to introduce 3 new Findbugs warning(s) in module(s) [bookkeeper-server] -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/260/
          Hide
          Ivan Kelly added a comment -

          Build failed because BOOKKEEPER-556 is not in

          Show
          Ivan Kelly added a comment - Build failed because BOOKKEEPER-556 is not in
          Hide
          Sijie Guo added a comment -

          lgtm +1. will retrigger the commit job. after that, will commit it.

          Show
          Sijie Guo added a comment - lgtm +1. will retrigger the commit job. after that, will commit it.
          Sijie Guo made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Sijie Guo added a comment -

          re-trigger the commit job.

          Show
          Sijie Guo added a comment - re-trigger the commit job.
          Sijie Guo made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Sijie Guo added a comment -

          seems that the patch has some conflicts, rebase to latest trunk. and trigger the pre commit job.

          Show
          Sijie Guo added a comment - seems that the patch has some conflicts, rebase to latest trunk. and trigger the pre commit job.
          Sijie Guo made changes -
          Attachment BOOKKEEPER-555.patch [ 12568716 ]
          Sijie Guo made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Sijie Guo made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-555

          Patch BOOKKEEPER-555.patch downloaded at Sat Feb 9 22:21:10 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          -1 FINDBUGS
          . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server]
          +1 TESTS
          . Tests run: 815
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/263/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-555 Patch BOOKKEEPER-555.patch downloaded at Sat Feb 9 22:21:10 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FINDBUGS . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server] +1 TESTS . Tests run: 815 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/263/
          Hide
          Sijie Guo added a comment -

          cancel the patch until findbug error is addressed.

          Ivan Kelly seems the findbug error is from CleanupChannelGroup. it warns that 'doesn't override equals'. but I am not sure we need to override this method, since we don't modify the class too much.

          Show
          Sijie Guo added a comment - cancel the patch until findbug error is addressed. Ivan Kelly seems the findbug error is from CleanupChannelGroup. it warns that 'doesn't override equals'. but I am not sure we need to override this method, since we don't modify the class too much.
          Sijie Guo made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Rakesh R added a comment -

          -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server]

          I think equals overriding will not cause any issues, its giving warning as CleanupChannelGroup has new field 'closed' defined.

          Hi Ivan/Sijie, Sorry to pitch in late as I got free time today only.
          By the way netty impl looks very nice. Just have few suggestions, could you please go through. As there is no functional problems, feel free riasing another jira to fix valid comments and go ahead with committing the current patch.

          • @ChannelPipelineCoverage annotation has been deprecated
            and use the alternative @Sharable annotation
          • Creates a new group with the specified name in CleanupChannelGroup like, rather than using the generated name.
            DefaultChannelGroup() { super("bookieServerCnxns"); }
          • I feel BookieRequestHandler can override channelDisconnected, channelConnected and do logging, will make debug much easier in fluctuating env.
          • Haven't seen the following var is used anywhere in BookieRequestHandler, please remove.
            private final ServerConfiguration conf;
          • 'boolean success = false;' in BookieRequestHandler is not required and please remove it, as read logic is using 'errorCode == BookieProtocol.EOK' to differentiate success/failure.
          • please organize imports for the classes:
            BookieNettyServer, BookieServer, BookieServerBean
          Show
          Rakesh R added a comment - -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [bookkeeper-server] I think equals overriding will not cause any issues, its giving warning as CleanupChannelGroup has new field 'closed' defined. Hi Ivan/Sijie, Sorry to pitch in late as I got free time today only. By the way netty impl looks very nice. Just have few suggestions, could you please go through. As there is no functional problems, feel free riasing another jira to fix valid comments and go ahead with committing the current patch. @ChannelPipelineCoverage annotation has been deprecated and use the alternative @Sharable annotation Creates a new group with the specified name in CleanupChannelGroup like, rather than using the generated name. DefaultChannelGroup() { super("bookieServerCnxns"); } I feel BookieRequestHandler can override channelDisconnected, channelConnected and do logging, will make debug much easier in fluctuating env. Haven't seen the following var is used anywhere in BookieRequestHandler, please remove. private final ServerConfiguration conf; 'boolean success = false;' in BookieRequestHandler is not required and please remove it, as read logic is using 'errorCode == BookieProtocol.EOK' to differentiate success/failure. please organize imports for the classes: BookieNettyServer, BookieServer, BookieServerBean
          Hide
          Ivan Kelly added a comment -

          New patch addresses Rakesh's comments except for the import thing. What do you mean by organise? Alphabetize?

          Show
          Ivan Kelly added a comment - New patch addresses Rakesh's comments except for the import thing. What do you mean by organise? Alphabetize?
          Ivan Kelly made changes -
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-555

          Patch 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Mon Feb 11 12:11:12 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 815
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/264/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-555 Patch 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Mon Feb 11 12:11:12 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 815 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/264/
          Hide
          Rakesh R added a comment -

          Thanks Ivan Kelly for the patch.

          What do you mean by organise? Alphabetize?

          Unused imports exists in these classes(BookieNettyServer, BookieServer, BookieServerBean), just wants to clear it

          Show
          Rakesh R added a comment - Thanks Ivan Kelly for the patch. What do you mean by organise? Alphabetize? Unused imports exists in these classes(BookieNettyServer, BookieServer, BookieServerBean), just wants to clear it
          Hide
          Ivan Kelly added a comment -

          Ah, had completely missed those. Fixed now.

          Show
          Ivan Kelly added a comment - Ah, had completely missed those. Fixed now.
          Ivan Kelly made changes -
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-555

          Patch 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Mon Feb 11 14:51:12 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 815
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/266/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-555 Patch 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch downloaded at Mon Feb 11 14:51:12 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 815 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/266/
          Hide
          Rakesh R added a comment -

          Thanks Ivan Kelly, latest patch looks nice. Apart from the following point, the patch is ready to go in +1.

          Just one clarification, latest patch BookieRequestHandler is not having @Sharable annotation. In my previous comment I mentioned to replace the @ChannelPipelineCoverage(which is deprecated) with @Sharable. Am I missing anything?

          Show
          Rakesh R added a comment - Thanks Ivan Kelly , latest patch looks nice. Apart from the following point, the patch is ready to go in +1. Just one clarification, latest patch BookieRequestHandler is not having @Sharable annotation. In my previous comment I mentioned to replace the @ChannelPipelineCoverage(which is deprecated) with @Sharable. Am I missing anything?
          Hide
          Ivan Kelly added a comment - - edited

          Rakesh R Re: @Sharable, you should put @Sharable on a ChannelHandler if more than one pipeline is going to use that ChannelHandler. Current we create a new handler per pipeline, and this doesn't seem to cause any performance issues. We could however share the ChannelHandler (and the decoder/encoder) as none of these actually old any state. However, I'd like to do that in a future JIRA and push this one in now, as there are a couple of things waiting on this.

          Therefore, since I have a +1, I'm going to push in.

          Show
          Ivan Kelly added a comment - - edited Rakesh R Re: @Sharable, you should put @Sharable on a ChannelHandler if more than one pipeline is going to use that ChannelHandler. Current we create a new handler per pipeline, and this doesn't seem to cause any performance issues. We could however share the ChannelHandler (and the decoder/encoder) as none of these actually old any state. However, I'd like to do that in a future JIRA and push this one in now, as there are a couple of things waiting on this. Therefore, since I have a +1, I'm going to push in.
          Hide
          Ivan Kelly added a comment -

          Committed r1445085. Thanks for reviewing guys.

          Show
          Ivan Kelly added a comment - Committed r1445085. Thanks for reviewing guys.
          Ivan Kelly made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in bookkeeper-trunk #99 (See https://builds.apache.org/job/bookkeeper-trunk/99/)
          BOOKKEEPER-555: Make BookieServer use Netty rather than a custom IO server (ivank) (Revision 1445085)

          Result = SUCCESS
          ivank :
          Files :

          • /zookeeper/bookkeeper/trunk/CHANGES.txt
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ResponseBuilder.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/NIOServerFactoryTest.java
          Show
          Hudson added a comment - Integrated in bookkeeper-trunk #99 (See https://builds.apache.org/job/bookkeeper-trunk/99/ ) BOOKKEEPER-555 : Make BookieServer use Netty rather than a custom IO server (ivank) (Revision 1445085) Result = SUCCESS ivank : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ResponseBuilder.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/NIOServerFactoryTest.java
          Ivan Kelly made changes -
          Parent BOOKKEEPER-575 [ 12634161 ]
          Issue Type Bug [ 1 ] Sub-task [ 7 ]
          Gavin made changes -
          Link This issue depends on BOOKKEEPER-556 [ BOOKKEEPER-556 ]
          Gavin made changes -
          Link This issue depends upon BOOKKEEPER-556 [ BOOKKEEPER-556 ]

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development