[BOOKKEEPER-538] Race condition in BookKeeper#close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2.0
• Assignee: Ivan Kelly
• Reporter: Ivan Kelly
• Created: 08/Jan/13 18:37
• Updated: 13/Feb/13 15:46
• Resolved: 10/Jan/13 18:14

Description

I've seen this with BookieAutoRecoveryTest. Basically, we interrupt and join the replicationworker thread, and then close the BookKeeper instance. This can have caused a bookkeeper operation that never finished. The executor runs it after #close has closed the BookieClient. The operation opens a connection and therefore we get a hang on releaseExternalResources().

Solution is pretty simple. We should shutdown all executors before closing the bookieClient. I'll attach a patch which does this.

Issue Links

• is duplicated by: BOOKKEEPER-462 ledger recovery test stuck occasionally