Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-533

TestSubAfterCloseSub fails strangely in tests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Example https://builds.apache.org/job/bookkeeper-trunk-precommit-build/204/

      It looks like the maven surefire process exits, as if System.exit() is being called. This should be the case since BOOKKEEPER-522, which removes all calls to System.exit()

      1. stack.txt
        39 kB
        Ivan Kelly
      2. hedwig-server.log
        24 kB
        Ivan Kelly
      3. BOOKKEEPER-533.diff
        0.5 kB
        Ivan Kelly
      4. BOOKKEEPER-533.diff
        0.5 kB
        Ivan Kelly
      5. BOOKKEEPER-533.diff
        1.0 kB
        Ivan Kelly
      6. BOOKKEEPER-533.diff
        0.9 kB
        Ivan Kelly
      7. BOOKKEEPER-533.diff
        4 kB
        Ivan Kelly
      8. BOOKKEEPER-533.diff
        4 kB
        Ivan Kelly
      9. BOOKKEEPER-533.diff
        4 kB
        Ivan Kelly
      10. BOOKKEEPER-533.diff
        4 kB
        Ivan Kelly
      11. BOOKKEEPER-533.diff
        12 kB
        Ivan Kelly
      12. BOOKKEEPER-513.diff
        12 kB
        Ivan Kelly
      13. BOOKKEEPER-513.diff
        12 kB
        Ivan Kelly
      14. 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch
        31 kB
        Ivan Kelly
      15. 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch
        31 kB
        Ivan Kelly
      16. 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch
        36 kB
        Ivan Kelly

        Issue Links

          Activity

          Ivan Kelly created issue -
          Ivan Kelly made changes -
          Field Original Value New Value
          Link This issue blocks BOOKKEEPER-513 [ BOOKKEEPER-513 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563416 ]
          Hide
          Ivan Kelly added a comment -

          Marking patch avail so jenkins picks it up

          Show
          Ivan Kelly added a comment - Marking patch avail so jenkins picks it up
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Ivan Kelly [ ikelly ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563417 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563418 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:11:42 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 1 testcase(s)
          -1 RAT
          . -1 the patch seems to introduce - new RAT warning(s)
          . WARNING: the current HEAD has RAT warning(s), they should be addressed ASAP
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 0
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          . There is at least one warning, please check

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/19/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:11:42 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 1 testcase(s) -1 RAT . -1 the patch seems to introduce - new RAT warning(s) . WARNING: the current HEAD has RAT warning(s), they should be addressed ASAP +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 0 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) . There is at least one warning, please check The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/19/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:11:12 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 1 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/206/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:11:12 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/206/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:14:14 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 1 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/20/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 13:14:14 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/20/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 15:40:33 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 1 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/21/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Sat Jan 5 15:40:33 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/21/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-513.diff [ 12563427 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 15:51:13 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          -1 TESTS - patch does not compile, cannot run testcases
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/208/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 15:51:13 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS - patch does not compile, cannot run testcases +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/208/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-513.diff [ 12563433 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:32:32 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/25/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:32:32 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/25/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:32:02 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/209/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:32:02 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/209/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:37:20 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/26/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:37:20 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/26/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:40:02 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/27/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:40:02 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/27/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:42:42 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/28/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 16:42:42 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/28/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 18:52:22 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/29/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 18:52:22 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/29/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 18:55:03 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/30/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-513.diff downloaded at Sat Jan 5 18:55:03 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/30/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563550 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563551 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:03:06 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          -1 COMPILE
          . +1 HEAD compiles
          . -1 patch does not compile
          . +1 the patch does not seem to introduce new javac warnings
          -1 TESTS - patch does not compile, cannot run testcases
          -1 DISTRO
          . -1 distro tarball fails with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/32/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:03:06 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/32/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563552 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:07:40 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/33/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:07:40 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/33/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:05:32 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . -1 patch does not compile
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          -1 TESTS - patch does not compile, cannot run testcases
          -1 DISTRO
          . -1 distro tarball fails with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/211/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:05:32 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/211/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:10:27 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/34/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:10:27 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/34/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:14:01 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/35/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:14:01 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/35/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:16:46 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/36/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:16:46 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/36/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:19:43 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/37/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:19:43 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/37/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:34:09 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/38/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 11:34:09 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/38/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563556 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 12:31:33 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/39/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 12:31:33 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/39/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563562 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:20:40 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/213/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:20:40 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/213/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:40:33 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 2
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/40/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:40:33 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 2 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/40/
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-533.diff [ 12563566 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:57:30 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/41/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 13:57:30 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/41/
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 14:26:31 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-debug/42/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 14:26:31 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/42/
          Ivan Kelly made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 15:48:41 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 3
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/214/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch BOOKKEEPER-533.diff downloaded at Mon Jan 7 15:48:41 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 3 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/214/
          Hide
          Ivan Kelly added a comment -

          Attached a log and stack dump of the failure. It seems to be blocking on a call to asyncCloseSubscription while waiting to acquire a monitor. This shouldn't be, as asyncCloseSubscription doesn't have any synchronization. This is very strange.

          Show
          Ivan Kelly added a comment - Attached a log and stack dump of the failure. It seems to be blocking on a call to asyncCloseSubscription while waiting to acquire a monitor. This shouldn't be, as asyncCloseSubscription doesn't have any synchronization. This is very strange.
          Ivan Kelly made changes -
          Attachment stack.txt [ 12563583 ]
          Attachment hedwig-server.log [ 12563584 ]
          Hide
          Ivan Kelly added a comment -

          http://docs.oracle.com/javase/1.4.2/docs/guide/misc/threadPrimitiveDeprecation.html

          I'm pretty sure this is whats going on. If you look at the stack.txt you'll see that the DeliveryManagerThread is being blocked in the classloader. I think this is stopping "new Callback<Void>" from running, as the class hasn't been loaded. It's a system resource. We should not be blocking it. I'm not sure how to fix this nicely. It may mean putting something into the server to allow us to manually suspend the delivery manager.

          Sijie Guo Could you explain the rationale for suspending the delivery manager thread, as I'm not 100% clear on it.

          Show
          Ivan Kelly added a comment - http://docs.oracle.com/javase/1.4.2/docs/guide/misc/threadPrimitiveDeprecation.html I'm pretty sure this is whats going on. If you look at the stack.txt you'll see that the DeliveryManagerThread is being blocked in the classloader. I think this is stopping "new Callback<Void>" from running, as the class hasn't been loaded. It's a system resource. We should not be blocking it. I'm not sure how to fix this nicely. It may mean putting something into the server to allow us to manually suspend the delivery manager. Sijie Guo Could you explain the rationale for suspending the delivery manager thread, as I'm not 100% clear on it.
          Hide
          Sijie Guo added a comment -

          suspending delivery manager is to simulate the case that closesub finished later than subscriber, which is the problem before fixing BOOKKEEPER-507.

          another question, if Thread.suspend is not suggested to be used, could this issue you described happened on other test cases using Thread.suspend? e.g. BookKeeperClusterTestCase#sleepBookie.

          Show
          Sijie Guo added a comment - suspending delivery manager is to simulate the case that closesub finished later than subscriber, which is the problem before fixing BOOKKEEPER-507 . another question, if Thread.suspend is not suggested to be used, could this issue you described happened on other test cases using Thread.suspend? e.g. BookKeeperClusterTestCase#sleepBookie.
          Hide
          Ivan Kelly added a comment -

          Thread.suspend is not suggested to be used, could this issue you described happened on other test cases using Thread.suspend?

          Yes, this is vulnerable too. I'll make a fix for this tomorrow, and will fix sleepBookie at the same time.

          Show
          Ivan Kelly added a comment - Thread.suspend is not suggested to be used, could this issue you described happened on other test cases using Thread.suspend? Yes, this is vulnerable too. I'll make a fix for this tomorrow, and will fix sleepBookie at the same time.
          Hide
          Ivan Kelly added a comment -

          Patch removes all the calls to Thread#suspend that we can remove. There's two calls to it that calls into ZooKeeper. We can't change those.

          Also cleaned up some places where "// VisibleForTesting" was used instead of the actual annotation.

          Show
          Ivan Kelly added a comment - Patch removes all the calls to Thread#suspend that we can remove. There's two calls to it that calls into ZooKeeper. We can't change those. Also cleaned up some places where "// VisibleForTesting" was used instead of the actual annotation.
          Ivan Kelly made changes -
          Attachment 0001-BOOKKEEPER-530-data-might-be-lost-during-compaction.patch [ 12563783 ]
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch 0001-BOOKKEEPER-530-data-might-be-lost-during-compaction.patch downloaded at Tue Jan 8 17:41:24 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 781
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/218/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch 0001-BOOKKEEPER-530-data-might-be-lost-during-compaction.patch downloaded at Tue Jan 8 17:41:24 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 781 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/218/
          Hide
          Ivan Kelly added a comment -

          Attached wrong patch last time.

          Show
          Ivan Kelly added a comment - Attached wrong patch last time.
          Ivan Kelly made changes -
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Tue Jan 8 18:21:23 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 4 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 779
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/219/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Tue Jan 8 18:21:23 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 779 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/219/
          Hide
          Flavio Junqueira added a comment -

          It looks good, one quick clarification: have you intentionally removed IndexCorruptionTest?

          Show
          Flavio Junqueira added a comment - It looks good, one quick clarification: have you intentionally removed IndexCorruptionTest?
          Ivan Kelly made changes -
          Ivan Kelly made changes -
          Attachment 0001-BOOKKEEPER-530-data-might-be-lost-during-compaction.patch [ 12563783 ]
          Hide
          Ivan Kelly added a comment - - edited

          Ah, I moved it so that it could access the syncThread. Forgot to add it again though. New patch has it.

          Show
          Ivan Kelly added a comment - - edited Ah, I moved it so that it could access the syncThread. Forgot to add it again though. New patch has it.
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Wed Jan 9 10:31:25 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 4 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 779
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          +1 Overall result, good!, no -1s

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/223/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Wed Jan 9 10:31:25 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 779 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/223/
          Hide
          Flavio Junqueira added a comment -

          The patch still looks wrong to me, IndexCorruptionTest is still being deleted and not added elsewhere. One indication that nothing changed is that the patch size is the same.

          Show
          Flavio Junqueira added a comment - The patch still looks wrong to me, IndexCorruptionTest is still being deleted and not added elsewhere. One indication that nothing changed is that the patch size is the same.
          Hide
          Ivan Kelly added a comment -

          This one has it.

          Show
          Ivan Kelly added a comment - This one has it.
          Ivan Kelly made changes -
          Hide
          Flavio Junqueira added a comment -

          +1, Thanks, Ivan. Committed revision 1430933.

          Show
          Flavio Junqueira added a comment - +1, Thanks, Ivan. Committed revision 1430933.
          Flavio Junqueira made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hadoop QA added a comment -

          Testing JIRA BOOKKEEPER-533

          Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Wed Jan 9 15:51:24 UTC 2013

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . -1 the patch contains 4 line(s) with trailing spaces
          . +1 the patch does not introduce any line longer than 120
          . +1 the patch does adds/modifies 5 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 FINDBUGS
          . +1 the patch does not seem to introduce new Findbugs warnings
          +1 TESTS
          . Tests run: 782
          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/228/

          Show
          Hadoop QA added a comment - Testing JIRA BOOKKEEPER-533 Patch 0001-BOOKKEEPER-533-TestSubAfterCloseSub-fails-strangely-.patch downloaded at Wed Jan 9 15:51:24 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 4 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 5 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 782 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/228/
          Hide
          Hudson added a comment -

          Integrated in bookkeeper-trunk2 #46 (See https://builds.apache.org/job/bookkeeper-trunk2/46/)
          BOOKKEEPER-533: TestSubAfterCloseSub fails strangely in tests (ivank via fpj) (Revision 1430933)

          Result = SUCCESS
          fpj :
          Files :

          • /zookeeper/bookkeeper/trunk/CHANGES.txt
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/IndexCorruptionTest.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java
          • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/IndexCorruptionTest.java
          • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
          • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
          • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/client/TestSubAfterCloseSub.java
          • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java
          • /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestDeadlock.java
          Show
          Hudson added a comment - Integrated in bookkeeper-trunk2 #46 (See https://builds.apache.org/job/bookkeeper-trunk2/46/ ) BOOKKEEPER-533 : TestSubAfterCloseSub fails strangely in tests (ivank via fpj) (Revision 1430933) Result = SUCCESS fpj : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/IndexCorruptionTest.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/IndexCorruptionTest.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/client/TestSubAfterCloseSub.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestDeadlock.java
          Ivan Kelly made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development