Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Otherwise it will run forever.

        Activity

        Ivan Kelly made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Flavio Junqueira added a comment -

        +1, thanks Ivan and Sijie. Committed revision 1426772.

        Show
        Flavio Junqueira added a comment - +1, thanks Ivan and Sijie. Committed revision 1426772.
        Flavio Junqueira made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-523

        Patch BOOKKEEPER-523.diff downloaded at Fri Dec 28 20:12:07 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 78 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 757
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        +1 Overall result, good!, no -1s

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/175/

        Show
        Hadoop QA added a comment - Testing JIRA BOOKKEEPER-523 Patch BOOKKEEPER-523.diff downloaded at Fri Dec 28 20:12:07 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 78 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 757 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/175/
        Sijie Guo made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sijie Guo made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Sijie Guo made changes -
        Attachment BOOKKEEPER-523.diff [ 12562603 ]
        Hide
        Sijie Guo added a comment -

        attach a rebased patch to latest trunk. I think after BOOKKEEPER-520, those issues would be resolved.

        Show
        Sijie Guo added a comment - attach a rebased patch to latest trunk. I think after BOOKKEEPER-520 , those issues would be resolved.
        Hide
        Flavio Junqueira added a comment -

        I verified that I get the out of memory error out of TestReplicationWorker even with trunk and that BookieFailureTest passes fine when run independently. BookieFailureTest still timed out here in the precommit build and it was after the commit of BOOKEEPER-520 r1424335 according to the timestamp.

        Show
        Flavio Junqueira added a comment - I verified that I get the out of memory error out of TestReplicationWorker even with trunk and that BookieFailureTest passes fine when run independently. BookieFailureTest still timed out here in the precommit build and it was after the commit of BOOKEEPER-520 r1424335 according to the timestamp.
        Hide
        Flavio Junqueira added a comment -

        Btw, I was also wondering if 60s is a good value or not. As a starting point it sounds good like a good guess for existing tests. For new tests, we could try to come up with a better guess on a per test basis instead of assuming that it has to be 60s every time.

        Show
        Flavio Junqueira added a comment - Btw, I was also wondering if 60s is a good value or not. As a starting point it sounds good like a good guess for existing tests. For new tests, we could try to come up with a better guess on a per test basis instead of assuming that it has to be 60s every time.
        Hide
        Flavio Junqueira added a comment - - edited

        I also got a hang on BookieFailureTest locally:

        testAsyncBK4[5](org.apache.bookkeeper.test.BookieFailureTest)  
        Time elapsed: 60.122 sec  <<< ERROR!
        java.lang.Exception: test timed out after 60000 milliseconds
                at java.lang.Object.wait(Native Method)
                at org.apache.bookkeeper.test.BookieFailureTest.auxTestReadWriteAsyncSingleClient (BookieFailureTest.java:182)
                at org.apache.bookkeeper.test.BookieFailureTest.testAsyncBK4
        (BookieFailureTest.java:120)
        

        I was not seeing this test failing before, is it a new issue?

        I also got an out of memory error on TestReplicationWorker:

        Running org.apache.bookkeeper.replication.TestReplicationWorker
        Exception in thread "ThreadedStreamConsumer" java.lang.OutOfMemoryError: Java heap space
        	at java.util.Arrays.copyOf 
        (Arrays.java:2882)
        	at java.lang.AbstractStringBuilder.expandCapacity
        (AbstractStringBuilder.java:100)
        	at java.lang.AbstractStringBuilder.append
        (AbstractStringBuilder.java:390)
        	at java.lang.StringBuffer.append
        (StringBuffer.java:224)
        	at org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMessage
        (ConsoleOutputFileReporter.java:115)
        	at org.apache.maven.surefire.report.MulticastingReporter.writeMessage (MulticastingReporter.java:101)
        	at org.apache.maven.surefire.report.TestSetRunListener.writeTestOutput (TestSetRunListener.java:99)
        	at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine (ForkClient.java:132)
        	at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run (ThreadedStreamConsumer.java:67)
        	at java.lang.Thread.run(Thread.java:680)
        
        Show
        Flavio Junqueira added a comment - - edited I also got a hang on BookieFailureTest locally: testAsyncBK4[5](org.apache.bookkeeper.test.BookieFailureTest) Time elapsed: 60.122 sec <<< ERROR! java.lang.Exception: test timed out after 60000 milliseconds at java.lang.Object.wait(Native Method) at org.apache.bookkeeper.test.BookieFailureTest.auxTestReadWriteAsyncSingleClient (BookieFailureTest.java:182) at org.apache.bookkeeper.test.BookieFailureTest.testAsyncBK4 (BookieFailureTest.java:120) I was not seeing this test failing before, is it a new issue? I also got an out of memory error on TestReplicationWorker: Running org.apache.bookkeeper.replication.TestReplicationWorker Exception in thread "ThreadedStreamConsumer" java.lang.OutOfMemoryError: Java heap space at java.util.Arrays.copyOf (Arrays.java:2882) at java.lang.AbstractStringBuilder.expandCapacity (AbstractStringBuilder.java:100) at java.lang.AbstractStringBuilder.append (AbstractStringBuilder.java:390) at java.lang.StringBuffer.append (StringBuffer.java:224) at org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMessage (ConsoleOutputFileReporter.java:115) at org.apache.maven.surefire.report.MulticastingReporter.writeMessage (MulticastingReporter.java:101) at org.apache.maven.surefire.report.TestSetRunListener.writeTestOutput (TestSetRunListener.java:99) at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine (ForkClient.java:132) at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run (ThreadedStreamConsumer.java:67) at java.lang.Thread.run(Thread.java:680)
        Hide
        Ivan Kelly added a comment -

        The 1 failure is unrelated. Its a test that would have hung otherwise.

        Show
        Ivan Kelly added a comment - The 1 failure is unrelated. Its a test that would have hung otherwise.
        Hide
        Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-523

        Patch 0002-BOOKKEEPER-523-Every-test-should-have-a-timeout.patch downloaded at Thu Dec 20 18:56:41 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 80 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        -1 TESTS
        . Tests run: 505
        . Tests failed: 0
        . Tests errors: 1

        . The patch failed the following testcases:

        .

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/165/

        Show
        Hadoop QA added a comment - Testing JIRA BOOKKEEPER-523 Patch 0002-BOOKKEEPER-523-Every-test-should-have-a-timeout.patch downloaded at Thu Dec 20 18:56:41 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 80 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS . Tests run: 505 . Tests failed: 0 . Tests errors: 1 . The patch failed the following testcases: . +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/165/
        Ivan Kelly made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ivan Kelly made changes -
        Field Original Value New Value
        Attachment 0002-BOOKKEEPER-523-Every-test-should-have-a-timeout.patch [ 12561955 ]
        Hide
        Ivan Kelly added a comment -

        Added a default timeout of 60 seconds to each testcase. No individual test case should take longer than that.

        Show
        Ivan Kelly added a comment - Added a default timeout of 60 seconds to each testcase. No individual test case should take longer than that.
        Ivan Kelly created issue -

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development