Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-520

BookieFailureTest hangs on precommit build

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.0
    • Component/s: None
    • Labels:
      None
    1. BOOKKEEPER-520.diff
      0.9 kB
      Ivan Kelly
    2. bookkeeper-server.log
      699 kB
      Ivan Kelly
    3. 0001-Fix-the-callback.patch
      6 kB
      Ivan Kelly
    4. BOOKKEEPER-520.diff
      7 kB
      Ivan Kelly
    5. BOOKKEEPER-520.diff
      7 kB
      Ivan Kelly
    6. BOOKKEEPER-520.diff
      7 kB
      Ivan Kelly
    7. BOOKKEEPER-520.diff
      7 kB
      Ivan Kelly
    8. BOOKKEEPER-520.diff
      8 kB
      Ivan Kelly
    9. BOOKKEEPER-520.diff
      9 kB
      Ivan Kelly
    10. BOOKKEEPER-520.diff
      10 kB
      Ivan Kelly
    11. BOOKKEEPER-520.diff
      10 kB
      Ivan Kelly
    12. 0001-BOOKKEEPER-520-BookieFailureTest-hangs-on-precommit-.patch
      7 kB
      Ivan Kelly
    13. stack-trace.txt
      31 kB
      Flavio Junqueira
    14. org.apache.bookkeeper.test.BookieFailureTest-output-halt.txt
      2.40 MB
      Flavio Junqueira
    15. BOOKKEEPER-520.diff
      6 kB
      Sijie Guo
    16. BOOKKEEPER-520.diff
      7 kB
      Sijie Guo

      Issue Links

        Activity

        Hide
        fpj Flavio Junqueira added a comment -

        agreed, I should I have created a new jira for this.

        Show
        fpj Flavio Junqueira added a comment - agreed, I should I have created a new jira for this.
        Hide
        ikelly Ivan Kelly added a comment -

        For future reference, if a JIRA already has a patch committed, either a new jira should be opened for amendments, or the previous should be reverted before applying the new one.

        Show
        ikelly Ivan Kelly added a comment - For future reference, if a JIRA already has a patch committed, either a new jira should be opened for amendments, or the previous should be reverted before applying the new one.
        Hide
        fpj Flavio Junqueira added a comment -

        +1, great job, sijie! Committed revision 1426349.

        Show
        fpj Flavio Junqueira added a comment - +1, great job, sijie! Committed revision 1426349.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Thu Dec 27 20:12:07 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . -1 the patch does not add/modify any testcase
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 765
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/172/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Thu Dec 27 20:12:07 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 765 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/172/
        Hide
        hustlmsp Sijie Guo added a comment -

        Attach a new patch to resolve the comments and slowbookie hang issue.

        Show
        hustlmsp Sijie Guo added a comment - Attach a new patch to resolve the comments and slowbookie hang issue.
        Hide
        hustlmsp Sijie Guo added a comment -

        I think the slowBookie issue is introduced by the latest patch, which do not send a request if unset doesn't occur in its write set. there is a case described below:

        + // E.g.
        + // ensemble (A, B, C, D), entry k is written to (A, B, D). An ensemble change
        + // happened to replace C with E. so entry k could not complete until C is
        + // replaced by E successfully. when ensemble change finished, it tried to
        + // unset entry k. but C is not in k's write set, so no entry is written again,
        + // no one trigger #sendAddSuccessCallbacks. so k would never complete.
        + //

        the fix would be straightforward as the example. we had to try to send success add callbacks when unset an bookie which isn't in write set, because there might be entries already completed but blocked for ensemble change to be completed.

        Show
        hustlmsp Sijie Guo added a comment - I think the slowBookie issue is introduced by the latest patch, which do not send a request if unset doesn't occur in its write set. there is a case described below: + // E.g. + // ensemble (A, B, C, D), entry k is written to (A, B, D). An ensemble change + // happened to replace C with E. so entry k could not complete until C is + // replaced by E successfully. when ensemble change finished, it tried to + // unset entry k. but C is not in k's write set, so no entry is written again, + // no one trigger #sendAddSuccessCallbacks. so k would never complete. + // the fix would be straightforward as the example. we had to try to send success add callbacks when unset an bookie which isn't in write set, because there might be entries already completed but blocked for ensemble change to be completed.
        Hide
        hustlmsp Sijie Guo added a comment - - edited

        The patch, however, does not really try to avoid the race itself, only its negative, which is not calling "lh.sendAddSuccessCallbacks()" for some entries.

        I'm not entirely sure of why you're moving the execution of writeComplete and readEntryComplete to separate thread in BookieClient. Is this for performance or is it related to the bug?

        there are two races here.

        1) writeComplete called in BookieClient due to channel could not be connected, is raced with successful writeComplete called in PerChannelBookieClient. I resolved it by submitting #writeComplete by ledger as what we did it in PerChannelBookieClient.

        2) change ensemble decrement blockAddCompletions in different thread. a success complete should wait until ensemble changed. but after ensemble changed, there is no chance to trigger sendAddSuccessCallbacks. so I removed "if (lh.pendingAddOps.peek() == this) {" to trigger success callbacks.

        Show
        hustlmsp Sijie Guo added a comment - - edited The patch, however, does not really try to avoid the race itself, only its negative, which is not calling "lh.sendAddSuccessCallbacks()" for some entries. I'm not entirely sure of why you're moving the execution of writeComplete and readEntryComplete to separate thread in BookieClient. Is this for performance or is it related to the bug? there are two races here. 1) writeComplete called in BookieClient due to channel could not be connected, is raced with successful writeComplete called in PerChannelBookieClient. I resolved it by submitting #writeComplete by ledger as what we did it in PerChannelBookieClient. 2) change ensemble decrement blockAddCompletions in different thread. a success complete should wait until ensemble changed. but after ensemble changed, there is no chance to trigger sendAddSuccessCallbacks. so I removed "if (lh.pendingAddOps.peek() == this) {" to trigger success callbacks.
        Hide
        fpj Flavio Junqueira added a comment -

        Great catch, Sijie! I had a look at the patch and in general it looks good to me. if i understand it correctly, the effect of the race in writeComplete is avoided by essentially removing this "if (lh.pendingAddOps.peek() == this) {". The patch, however, does not really try to avoid the race itself, only its negative, which is not calling "lh.sendAddSuccessCallbacks()" for some entries.

        I'm not entirely sure of why you're moving the execution of writeComplete and readEntryComplete to separate thread in BookieClient. Is this for performance or is it related to the bug?

        In unsetSuccessAndSendWriteRequest, it might be a good idea to update the comment the if statement:

                   if (toSend == null || !writeSet.contains(bookieIndex)) {
                     // this addOp hasn't yet had its mac computed. When the mac is
                     // computed, its write requests will be sent, so no need to send it
                     // now
        

        I checked the pre-commit build, and the problem seems to be with SlowBookieTest. First, we observe this:

        Running org.apache.bookkeeper.client.SlowBookieTest
        Running org.apache.bookkeeper.client.LedgerRecoveryTest
        Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.991 sec
        

        no report about failures and errors. Second, we get the following (not clarifying at all) error message:

        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD FAILURE
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 41:54.662s
        [INFO] Finished at: Thu Dec 27 09:09:17 UTC 2012
        [INFO] Final Memory: 21M/401M
        [INFO] ------------------------------------------------------------------------
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.9:test (default-test) on project bookkeeper-server: Failure or timeout -> [Help 1]
        

        I'm not sure how this error relates to this patch, if at all.

        Show
        fpj Flavio Junqueira added a comment - Great catch, Sijie! I had a look at the patch and in general it looks good to me. if i understand it correctly, the effect of the race in writeComplete is avoided by essentially removing this "if (lh.pendingAddOps.peek() == this) {". The patch, however, does not really try to avoid the race itself, only its negative, which is not calling "lh.sendAddSuccessCallbacks()" for some entries. I'm not entirely sure of why you're moving the execution of writeComplete and readEntryComplete to separate thread in BookieClient. Is this for performance or is it related to the bug? In unsetSuccessAndSendWriteRequest, it might be a good idea to update the comment the if statement: if (toSend == null || !writeSet.contains(bookieIndex)) { // this addOp hasn't yet had its mac computed. When the mac is // computed, its write requests will be sent, so no need to send it // now I checked the pre-commit build, and the problem seems to be with SlowBookieTest. First, we observe this: Running org.apache.bookkeeper.client.SlowBookieTest Running org.apache.bookkeeper.client.LedgerRecoveryTest Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.991 sec no report about failures and errors. Second, we get the following (not clarifying at all) error message: [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 41:54.662s [INFO] Finished at: Thu Dec 27 09:09:17 UTC 2012 [INFO] Final Memory: 21M/401M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.9:test (default-test) on project bookkeeper-server: Failure or timeout -> [Help 1] I'm not sure how this error relates to this patch, if at all.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Thu Dec 27 08:22:07 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . -1 the patch does not add/modify any testcase
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        -1 TESTS - patch does not compile, cannot run testcases
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/171/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Thu Dec 27 08:22:07 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS - patch does not compile, cannot run testcases +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/171/
        Hide
        hustlmsp Sijie Guo added a comment -

        attach a patch to fix this issue according to previous comment. beside that, improve unsetSuccessAndSendWriteRequest to just unset those entries who's write set contain the failed bookie.

        run BookieFailureTest using 'while [ 0 lt 10 ]; do mvn test -Dtest=BookieFailureTest; echo '----'; done'. it doesn't hang for one hour.

        Show
        hustlmsp Sijie Guo added a comment - attach a patch to fix this issue according to previous comment. beside that, improve unsetSuccessAndSendWriteRequest to just unset those entries who's write set contain the failed bookie. run BookieFailureTest using 'while [ 0 lt 10 ]; do mvn test -Dtest=BookieFailureTest; echo ' ----'; done'. it doesn't hang for one hour.
        Hide
        hustlmsp Sijie Guo added a comment -

        did more investigation on this issue. it was caused by some race condition on blockAddCompletions.

            void sendAddSuccessCallbacks() {
                // Start from the head of the queue and proceed while there are
                // entries that have had all their responses come back
                PendingAddOp pendingAddOp;
                while ((pendingAddOp = pendingAddOps.peek()) != null
                       && blockAddCompletions.get() == 0) {
                    if (!pendingAddOp.completed) {
                        return;
                    }   
                    pendingAddOps.remove();
                    lastAddConfirmed = pendingAddOp.entryId;
                    pendingAddOp.submitCallback(BKException.Code.OK);
                }   
            } 
        

        when sendAddSuccessCallback it would check blockAddCompletions (means how many operations are trying to change ensemble). if some entries failed and tried to handleBookieFailure, it would try to acquire blockAddCompletions as below:

                final ArrayList<InetSocketAddress> newEnsemble = new ArrayList<InetSocketAddress>();
                long completions = blockAddCompletions.incrementAndGet();
        
                // avoid parallel ensemble changes to same ensemble.
                synchronized (metadata) {
                    if (!metadata.currentEnsemble.get(bookieIndex).equals(addr)) {
                        // ensemble has already changed, failure of this addr is immaterial
                        LOG.warn("Write did not succeed to {}, bookieIndex {}, but we have already fixed it.",
                                 addr, bookieIndex);
                        completions = blockAddCompletions.decrementAndGet();
                        return;
                    }
        

        if these two codes run in different threads, the race happened, and since the responses for first entry already arrived and tried to send add success callback but failed. so no other response came in to trigger #sendAddSuccessCallbacks.

        and the root cause is #writeComplete callback runs in different thread, in BookieClient#addEntry. if the client failed to connect target bookie, it failed all the #writeCompletes in its thread not submit by ledgerId order.

        Show
        hustlmsp Sijie Guo added a comment - did more investigation on this issue. it was caused by some race condition on blockAddCompletions. void sendAddSuccessCallbacks() { // Start from the head of the queue and proceed while there are // entries that have had all their responses come back PendingAddOp pendingAddOp; while ((pendingAddOp = pendingAddOps.peek()) != null && blockAddCompletions.get() == 0) { if (!pendingAddOp.completed) { return ; } pendingAddOps.remove(); lastAddConfirmed = pendingAddOp.entryId; pendingAddOp.submitCallback(BKException.Code.OK); } } when sendAddSuccessCallback it would check blockAddCompletions (means how many operations are trying to change ensemble). if some entries failed and tried to handleBookieFailure, it would try to acquire blockAddCompletions as below: final ArrayList<InetSocketAddress> newEnsemble = new ArrayList<InetSocketAddress>(); long completions = blockAddCompletions.incrementAndGet(); // avoid parallel ensemble changes to same ensemble. synchronized (metadata) { if (!metadata.currentEnsemble.get(bookieIndex).equals(addr)) { // ensemble has already changed, failure of this addr is immaterial LOG.warn( "Write did not succeed to {}, bookieIndex {}, but we have already fixed it." , addr, bookieIndex); completions = blockAddCompletions.decrementAndGet(); return ; } if these two codes run in different threads, the race happened, and since the responses for first entry already arrived and tried to send add success callback but failed. so no other response came in to trigger #sendAddSuccessCallbacks. and the root cause is #writeComplete callback runs in different thread, in BookieClient#addEntry. if the client failed to connect target bookie, it failed all the #writeCompletes in its thread not submit by ledgerId order.
        Hide
        hustlmsp Sijie Guo added a comment -

        2012-12-27 00:33:11,702 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 14 , ignoring
        2012-12-27 00:33:11,702 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 16 , ignoring
        2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 25 , ignoring
        2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 28 , ignoring
        2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 35 , ignoring
        2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 46 , ignoring
        2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 55 , ignoring
        2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 59 , ignoring
        2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 62 , ignoring
        2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 65 , ignoring
        2012-12-27 00:33:11,705 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 74 , ignoring
        2012-12-27 00:33:11,705 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 80 , ignoring
        2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 83 , ignoring
        2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 85 , ignoring
        2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 86 , ignoring
        2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 91 , ignoring
        2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 92 , ignoring
        2012-12-27 00:33:11,707 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 94 , ignoring
        2012-12-27 00:33:11,707 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 98 , ignoring
        2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 100 , ignoring
        2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 101 , ignoring
        2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 103 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 104 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 106 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 107 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 109 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 110 , ignoring
        2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 112 , ignoring
        2012-12-27 00:33:11,710 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 113 , ignoring
        2012-12-27 00:33:11,710 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for

        Saw lots of unexpected add responses received. Not sure whether they caused hanging. But it seems that the problem is caused by some kind of race on addCompletions: channel connected executing adding entry to addCompletions, channel disconnected, addCompletions are error out. if some one added completion after error out, the added completion might not be executed, so no one callback and the test hangs on waiting for callback.

        Show
        hustlmsp Sijie Guo added a comment - 2012-12-27 00:33:11,702 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 14 , ignoring 2012-12-27 00:33:11,702 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 16 , ignoring 2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 25 , ignoring 2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 28 , ignoring 2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 35 , ignoring 2012-12-27 00:33:11,703 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 46 , ignoring 2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 55 , ignoring 2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 59 , ignoring 2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 62 , ignoring 2012-12-27 00:33:11,704 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 65 , ignoring 2012-12-27 00:33:11,705 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 74 , ignoring 2012-12-27 00:33:11,705 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 80 , ignoring 2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 83 , ignoring 2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 85 , ignoring 2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 86 , ignoring 2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 91 , ignoring 2012-12-27 00:33:11,706 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 92 , ignoring 2012-12-27 00:33:11,707 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 94 , ignoring 2012-12-27 00:33:11,707 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 98 , ignoring 2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 100 , ignoring 2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 101 , ignoring 2012-12-27 00:33:11,708 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 103 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 104 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 106 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 107 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 109 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 110 , ignoring 2012-12-27 00:33:11,709 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 112 , ignoring 2012-12-27 00:33:11,710 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for ledger: 3, entry: 113 , ignoring 2012-12-27 00:33:11,710 - ERROR - [pool-28-thread-1:PerChannelBookieClient@574] - Unexpected add response received from bookie: /192.168.1.105:15005 for Saw lots of unexpected add responses received. Not sure whether they caused hanging. But it seems that the problem is caused by some kind of race on addCompletions: channel connected executing adding entry to addCompletions, channel disconnected, addCompletions are error out. if some one added completion after error out, the added completion might not be executed, so no one callback and the test hangs on waiting for callback.
        Hide
        fpj Flavio Junqueira added a comment -

        Here are the test logs for a run that stalled for me.

        Show
        fpj Flavio Junqueira added a comment - Here are the test logs for a run that stalled for me.
        Hide
        fpj Flavio Junqueira added a comment -

        I'm not exactly sure why, but I can see in the test logs that it stops here:

        2012-12-27 00:33:22,334 - INFO  - [main:BookKeeperClusterTestCase@103] - Tearing down test null
        

        Note that I have also uploaded a stack trace before, it may help.

        Show
        fpj Flavio Junqueira added a comment - I'm not exactly sure why, but I can see in the test logs that it stops here: 2012-12-27 00:33:22,334 - INFO - [main:BookKeeperClusterTestCase@103] - Tearing down test null Note that I have also uploaded a stack trace before, it may help.
        Hide
        ewenpower liaowenrui added a comment -

        hi,Flavio.why BookieFailureTest is still hanging?

        Show
        ewenpower liaowenrui added a comment - hi,Flavio.why BookieFailureTest is still hanging?
        Hide
        fpj Flavio Junqueira added a comment -

        BookieFailureTest is still hanging, uploading another stack trace.

        Show
        fpj Flavio Junqueira added a comment - BookieFailureTest is still hanging, uploading another stack trace.
        Hide
        hudson Hudson added a comment -

        Integrated in bookkeeper-trunk #880 (See https://builds.apache.org/job/bookkeeper-trunk/880/)
        BOOKKEEPER-520: BookieFailureTest hangs on precommit build (ivank via sijie) (Revision 1424335)

        Result = SUCCESS
        sijie :
        Files :

        • /zookeeper/bookkeeper/trunk/CHANGES.txt
        • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
        • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
        • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
        Show
        hudson Hudson added a comment - Integrated in bookkeeper-trunk #880 (See https://builds.apache.org/job/bookkeeper-trunk/880/ ) BOOKKEEPER-520 : BookieFailureTest hangs on precommit build (ivank via sijie) (Revision 1424335) Result = SUCCESS sijie : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
        Hide
        hustlmsp Sijie Guo added a comment -

        committed as r1424335. thanks Ivan.

        Show
        hustlmsp Sijie Guo added a comment - committed as r1424335. thanks Ivan.
        Hide
        hustlmsp Sijie Guo added a comment -

        lgtm +1. thanks Ivan. will commit it.

        Show
        hustlmsp Sijie Guo added a comment - lgtm +1. thanks Ivan. will commit it.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch 0001-BOOKKEEPER-520-BookieFailureTest-hangs-on-precommit-.patch downloaded at Wed Dec 19 18:11:25 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 1 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 505
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        +1 Overall result, good!, no -1s

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/156/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch 0001-BOOKKEEPER-520-BookieFailureTest-hangs-on-precommit-.patch downloaded at Wed Dec 19 18:11:25 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 505 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/156/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 18:01:25 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/155/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 18:01:25 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/155/
        Hide
        ikelly Ivan Kelly added a comment -

        Turns out there was a race in handle bookie failure, which was causing the client to try to find a new bookie, but there would be none and it would fail. This should fix a number of -6 errors I've seen recently. Also fixes the callback for BookieFailureTest.

        Show
        ikelly Ivan Kelly added a comment - Turns out there was a race in handle bookie failure, which was causing the client to try to find a new bookie, but there would be none and it would fail. This should fix a number of -6 errors I've seen recently. Also fixes the callback for BookieFailureTest.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:55:56 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/13/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:55:56 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/13/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:42:15 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 6
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK2[1](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK2[2](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK1[3](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK3[3](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK4[3](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK2[5](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/153/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:42:15 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS . Tests run: 48 . Tests failed: 6 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK2 [1] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK2 [2] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK1 [3] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK3 [3] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK4 [3] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK2 [5] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/153/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:39:29 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 5
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK3[0](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK3[1](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK2[2](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK1[3](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK2[5](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/11/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:39:29 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 TESTS . Tests run: 48 . Tests failed: 5 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK3 [0] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK3 [1] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK2 [2] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK1 [3] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK2 [5] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/11/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:28:29 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/10/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:28:29 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/10/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:24:58 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/9/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:24:58 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/9/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:19:46 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/8/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:19:46 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/8/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:16:45 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/7/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:16:45 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/7/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:03:55 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 3
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK2[0](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK1[3](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK3[5](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/6/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 17:03:55 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 TESTS . Tests run: 48 . Tests failed: 3 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK2 [0] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK1 [3] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK3 [5] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/6/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:59:27 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/5/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:59:27 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/5/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:26:15 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 3
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK4[0](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK3[2](org.apache.bookkeeper.test.BookieFailureTest)
        . testAsyncBK4[3](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/4/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:26:15 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 TESTS . Tests run: 48 . Tests failed: 3 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK4 [0] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK3 [2] (org.apache.bookkeeper.test.BookieFailureTest) . testAsyncBK4 [3] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/4/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:21:26 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        -1 COMPILE
        . +1 HEAD compiles
        . -1 patch does not compile
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        -1 TESTS - patch does not compile, cannot run testcases
        -1 DISTRO
        . -1 distro tarball fails with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/149/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:21:26 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/149/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:19:17 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . -1 the patch contains 1 line(s) with trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        -1 COMPILE
        . +1 HEAD compiles
        . -1 patch does not compile
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS - patch does not compile, cannot run testcases
        -1 DISTRO
        . -1 distro tarball fails with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/3/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:19:17 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . -1 the patch contains 1 line(s) with trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/3/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:11:20 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 1
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK1[1](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/2/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch BOOKKEEPER-520.diff downloaded at Wed Dec 19 16:11:20 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 TESTS . Tests run: 48 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK1 [1] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/2/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 16:02:59 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 TESTS
        . Tests run: 48
        . Tests failed: 1
        . Tests errors: 0

        . The patch failed the following testcases:

        . testAsyncBK2[3](org.apache.bookkeeper.test.BookieFailureTest)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-debug/1/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 16:02:59 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 TESTS . Tests run: 48 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testAsyncBK2 [3] (org.apache.bookkeeper.test.BookieFailureTest) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-debug/1/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 15:51:00 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        +1 Overall result, good!, no -1s

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/148/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 15:51:00 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/148/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-520

        Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 15:43:21 UTC 2012

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . +1 the patch does adds/modifies 2 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 48
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        +1 Overall result, good!, no -1s

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/147/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA BOOKKEEPER-520 Patch 0001-Fix-the-callback.patch downloaded at Wed Dec 19 15:43:21 UTC 2012 ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 48 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/147/
        Hide
        ikelly Ivan Kelly added a comment -

        Fix the callback and put it through again.

        Show
        ikelly Ivan Kelly added a comment - Fix the callback and put it through again.
        Hide
        ikelly Ivan Kelly added a comment -

        The hang is another of these cases where the assert is in a callback. No idea about root cause though

        Show
        ikelly Ivan Kelly added a comment - The hang is another of these cases where the assert is in a callback. No idea about root cause though
        Hide
        ikelly Ivan Kelly added a comment -

        Not patch available. I want Jenkins to pick up the patch.

        Show
        ikelly Ivan Kelly added a comment - Not patch available. I want Jenkins to pick up the patch.

          People

          • Assignee:
            hustlmsp Sijie Guo
            Reporter:
            ikelly Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development