Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-213

PerChannelBookieClient calls the wrong errorOut function when encountering an exception

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0
    • Component/s: None
    • Labels:
      None

      Description

      In PerChannelBookieClient.java, addEntry calls errorOutReadKey on encountering an exception instead of errorOutAddKey.

      1. BK-213.patch
        0.8 kB
        Aniruddha

        Activity

        Aniruddha created issue -
        Hide
        Flavio Junqueira added a comment -

        Hi Aniruddha, Great that you spotted it, thanks for reporting. Do you want to produce a patch? We also need to fix the log message right before.

        Show
        Flavio Junqueira added a comment - Hi Aniruddha, Great that you spotted it, thanks for reporting. Do you want to produce a patch? We also need to fix the log message right before.
        Hide
        Aniruddha added a comment -

        I will submit a patch soon.

        Show
        Aniruddha added a comment - I will submit a patch soon.
        Hide
        Flavio Junqueira added a comment -

        Aniruddha, I was wondering if you're still planning on submitting a patch for this issue.

        Show
        Flavio Junqueira added a comment - Aniruddha, I was wondering if you're still planning on submitting a patch for this issue.
        Aniruddha made changes -
        Field Original Value New Value
        Attachment BK-213.patch [ 12523044 ]
        Hide
        Aniruddha added a comment -

        Sorry, forgot about this issue. I just submitted the patch.

        Show
        Aniruddha added a comment - Sorry, forgot about this issue. I just submitted the patch.
        Hide
        Sijie Guo added a comment -

        thanks, Aniruddha. the patch is good. just one place, it would be better to change the line of error message above your change

        Show
        Sijie Guo added a comment - thanks, Aniruddha. the patch is good. just one place, it would be better to change the line of error message above your change
        Aniruddha made changes -
        Attachment BK-213.patch [ 12523257 ]
        Hide
        Aniruddha added a comment -

        Made that change.

        Show
        Aniruddha added a comment - Made that change.
        Aniruddha made changes -
        Attachment BK-213.patch [ 12523044 ]
        Hide
        Sijie Guo added a comment -

        the patch is good to me. +1.

        Show
        Sijie Guo added a comment - the patch is good to me. +1.
        Hide
        Sijie Guo added a comment -

        committed as r1327761. Thanks, Aniruddha.

        Show
        Sijie Guo added a comment - committed as r1327761. Thanks, Aniruddha.
        Sijie Guo made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.1.0 [ 12319145 ]
        Resolution Fixed [ 1 ]
        Hide
        Sijie Guo added a comment -

        one thing that I can't find Aniruddha in the assignee list, so I have no idea how to change the assignee to him.

        Is there anyone tell me how to do that?

        Show
        Sijie Guo added a comment - one thing that I can't find Aniruddha in the assignee list, so I have no idea how to change the assignee to him. Is there anyone tell me how to do that?
        Hide
        Hudson added a comment -

        Integrated in bookkeeper-trunk #466 (See https://builds.apache.org/job/bookkeeper-trunk/466/)
        BOOKKEEPER-213: PerChannelBookieClient calls the wrong errorOut function when encountering an exception (Aniruddha via sijie) (Revision 1327761)

        Result = ABORTED
        sijie :
        Files :

        • /zookeeper/bookkeeper/trunk/CHANGES.txt
        • /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
        Show
        Hudson added a comment - Integrated in bookkeeper-trunk #466 (See https://builds.apache.org/job/bookkeeper-trunk/466/ ) BOOKKEEPER-213 : PerChannelBookieClient calls the wrong errorOut function when encountering an exception (Aniruddha via sijie) (Revision 1327761) Result = ABORTED sijie : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
        Flavio Junqueira made changes -
        Assignee Aniruddha [ i0exception ]
        Ivan Kelly made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Aniruddha
            Reporter:
            Aniruddha
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development