Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-137

Do not create Ledger index files until absolutely necessary.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0
    • Component/s: None
    • Labels:
      None

      Description

      This is an optimization to speed up the case where we have many ledgers and are writing to them at random (a benchmark case we currently have). Currently, we create the ledger index file and write the first 1k of it to disk immediately. With a lot of ledgers being randomly written to, this means a lot of random writes on the ledger disk. This fix postpones the creation of the index file and writing of the first 1k until the first flush of the ledger.

      1. BOOKKEEPER-137.diff
        19 kB
        Ivan Kelly
      2. BOOKKEEPER-137.diff
        33 kB
        Ivan Kelly
      3. BOOKKEEPER-137.diff
        33 kB
        Ivan Kelly
      4. BOOKKEEPER-137.diff
        33 kB
        Ivan Kelly
      5. BOOKKEEPER-137.diff
        33 kB
        Ivan Kelly

        Issue Links

          Activity

          Ivan Kelly made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Ivan Kelly made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-137.diff [ 12513827 ]
          Ivan Kelly made changes -
          Link This issue is blocked by BOOKKEEPER-165 [ BOOKKEEPER-165 ]
          Ivan Kelly made changes -
          Link This issue is blocked by BOOKKEEPER-135 [ BOOKKEEPER-135 ]
          Ivan Kelly made changes -
          Link This issue is blocked by BOOKKEEPER-136 [ BOOKKEEPER-136 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-137.diff [ 12513648 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-137.diff [ 12512172 ]
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ivan Kelly made changes -
          Attachment BOOKKEEPER-137.diff [ 12512161 ]
          Ivan Kelly made changes -
          Link This issue is blocked by BOOKKEEPER-136 [ BOOKKEEPER-136 ]
          Ivan Kelly made changes -
          Link This issue is blocked by BOOKKEEPER-135 [ BOOKKEEPER-135 ]
          Ivan Kelly made changes -
          Field Original Value New Value
          Attachment BOOKKEEPER-137.diff [ 12505911 ]
          Ivan Kelly created issue -

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development