Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-1021

Improve the merge script to handle github reviews api

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.5.0
    • build
    • None

    Description

      Current script doesn't handle the new reviews API.

      We need to improve the merge script to handle the new review API.

      https://developer.github.com/v3/pulls/reviews/

      We can do similar thing like what DistributedLog is doing.

      https://github.com/apache/incubator-distributedlog/blob/master/scripts/dev/dl-merge-pr.py

      Attachments

        Issue Links

          Activity

            People

              sijie@apache.org Sijie Guo
              sijie@apache.org Sijie Guo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: