Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-972

fix packagetest package remove logic

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: 0.6.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      Right now the packageRemove test logic relies on brittle tags for filenames that are considered to be 'system' on debian. We should simply have a list of such locations in our test code since it'll be way easier to maintain compared to hundreds of tags sprinkled all over the xml files.

        Activity

        Hide
        rvs Roman Shaposhnik added a comment -

        This patch restores the '/.' locations (which I mistakenly took out in a previous patch) and also modifies the test logic accordingly.

        Show
        rvs Roman Shaposhnik added a comment - This patch restores the '/.' locations (which I mistakenly took out in a previous patch) and also modifies the test logic accordingly.
        Hide
        cos Konstantin Boudnik added a comment -

        +1

        Show
        cos Konstantin Boudnik added a comment - +1
        Hide
        cos Konstantin Boudnik added a comment -

        Roman Shaposhnik I don't see this committed yet. Do you need any help with it?

        Show
        cos Konstantin Boudnik added a comment - Roman Shaposhnik I don't see this committed yet. Do you need any help with it?
        Hide
        rvs Roman Shaposhnik added a comment -

        Konstantin Boudnik this is weird. it feels like part of this patch got committed, but some parts did not. I'll take a look at it next week in more details.

        Show
        rvs Roman Shaposhnik added a comment - Konstantin Boudnik this is weird. it feels like part of this patch got committed, but some parts did not. I'll take a look at it next week in more details.
        Hide
        cos Konstantin Boudnik added a comment -

        ping?

        Show
        cos Konstantin Boudnik added a comment - ping?
        Hide
        cos Konstantin Boudnik added a comment -

        I have moved this to 0.9.0. Roman Shaposhnik - we haven't seen the manifestation of it in the latest series of package tests, have we? If so - please close this to avoid further confusions.

        Show
        cos Konstantin Boudnik added a comment - I have moved this to 0.9.0. Roman Shaposhnik - we haven't seen the manifestation of it in the latest series of package tests, have we? If so - please close this to avoid further confusions.
        Hide
        rvs Roman Shaposhnik added a comment -

        Yup. I believe this should be fixed now (or at least not reproducible)

        Show
        rvs Roman Shaposhnik added a comment - Yup. I believe this should be fixed now (or at least not reproducible)

          People

          • Assignee:
            rvs Roman Shaposhnik
            Reporter:
            rvs Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development