Bigtop
  1. Bigtop
  2. BIGTOP-869

hadoop preun should not stop services itself on behalf of its subpackages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Right now we have the following:

       %preun
       if [ "$1" = 0 ]; then
        # Stop any services that might be running
        for service in %{hadoop_services}
        do
           service hadoop-$service stop 1>/dev/null 2>/dev/null || :
        done
         %{alternatives_cmd} --remove %{name}-conf %{etc_hadoop}/conf.empty || :
       fi
      

      But its subpackage also stop the services.
      Doing stop from from the main package AND the subpackages break the single responsibility principle.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        54s 1 Bruno Mahé 12/Mar/13 06:54
        In Progress In Progress Patch Available Patch Available
        12s 1 Bruno Mahé 12/Mar/13 06:54
        Patch Available Patch Available Resolved Resolved
        4d 14h 35m 1 Bruno Mahé 16/Mar/13 21:30
        Resolved Resolved Closed Closed
        3s 1 Bruno Mahé 16/Mar/13 21:30
        Roman Shaposhnik made changes -
        Fix Version/s 0.6.0 [ 12323895 ]
        Bruno Mahé made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Bruno Mahé made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Roman Shaposhnik added a comment -

        +1. Please commit.

        Show
        Roman Shaposhnik added a comment - +1. Please commit.
        Bruno Mahé made changes -
        Bruno Mahé made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Hide
        Bruno Mahé added a comment -

        Here is a patch

        Show
        Bruno Mahé added a comment - Here is a patch
        Bruno Mahé made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Bruno Mahé created issue -

          People

          • Assignee:
            Bruno Mahé
            Reporter:
            Bruno Mahé
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development