Bigtop
  1. Bigtop
  2. BIGTOP-869

hadoop preun should not stop services itself on behalf of its subpackages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Right now we have the following:

       %preun
       if [ "$1" = 0 ]; then
        # Stop any services that might be running
        for service in %{hadoop_services}
        do
           service hadoop-$service stop 1>/dev/null 2>/dev/null || :
        done
         %{alternatives_cmd} --remove %{name}-conf %{etc_hadoop}/conf.empty || :
       fi
      

      But its subpackage also stop the services.
      Doing stop from from the main package AND the subpackages break the single responsibility principle.

        Activity

        Hide
        Bruno Mahé added a comment -

        Here is a patch

        Show
        Bruno Mahé added a comment - Here is a patch
        Hide
        Roman Shaposhnik added a comment -

        +1. Please commit.

        Show
        Roman Shaposhnik added a comment - +1. Please commit.

          People

          • Assignee:
            Bruno Mahé
            Reporter:
            Bruno Mahé
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development