Bigtop
  1. Bigtop
  2. BIGTOP-781

Bigtop packages seem to have a bunch of parasitic provides

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Component/s: Debian, RPM
    • Labels:
      None

      Description

      Here's what it looks like on the RPM sied of things:

      $ grep Provides: bigtop-packages/src/rpm/*/SPECS/*
      bigtop-packages/src/rpm/bigtop-jsvc/SPECS/bigtop-jsvc.spec:Provides: jsvc
      bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec:Provides: hadoop
      bigtop-packages/src/rpm/hbase/SPECS/hbase.spec:Provides: %{name}-master
      bigtop-packages/src/rpm/hbase/SPECS/hbase.spec:Provides: %{name}-regionserver
      bigtop-packages/src/rpm/hive/SPECS/hive.spec:Provides: hive
      bigtop-packages/src/rpm/hive/SPECS/hive.spec:Provides: %{name}-server
      bigtop-packages/src/rpm/hive/SPECS/hive.spec:Provides: %{name}-metastore
      bigtop-packages/src/rpm/hive/SPECS/hive.spec:Provides: %{name}-hbase
      bigtop-packages/src/rpm/hue/SPECS/hue.spec:Provides: %{name}-common = %{version}, config(%{name}-common) = %{version}
      bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec:Provides: sqoop-metastore
      bigtop-packages/src/rpm/zookeeper/SPECS/zookeeper.spec:Provides: %{svc_zookeeper}
      
      

      and here's the DEB side:

      bigtop-packages/src/deb/hadoop/control:Provides: hadoop
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-doc
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-conf-pseudo
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-mapreduce-historyserver
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-yarn-nodemanager
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-yarn-resourcemanager
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-yarn-proxyserver
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-hdfs-namenode
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-hdfs-secondarynamenode
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-hdfs-zkfc
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-hdfs-datanode
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-httpfs
      bigtop-packages/src/deb/hadoop/control:Provides: hadoop-client
      bigtop-packages/src/deb/mahout/control:Provides: mahout-doc
      bigtop-packages/src/deb/solr/control:Provides: solr-doc
      

      I really don't think any of them are needed, but I'd love to hear otherwise.

      1. BIGTOP-781.patch.txt
        10 kB
        Roman Shaposhnik

        Activity

        Roman Shaposhnik created issue -
        Hide
        Mark Grover added a comment -

        +1 on the idea!

        Show
        Mark Grover added a comment - +1 on the idea!
        Hide
        Peter Linnell added a comment -

        The only word of caution here is of provides are removed, then Requires need to be aligned, so meta packages like hue do not break on install or upgrade. +1 on the idea.

        Show
        Peter Linnell added a comment - The only word of caution here is of provides are removed, then Requires need to be aligned, so meta packages like hue do not break on install or upgrade. +1 on the idea.
        Hide
        Roman Shaposhnik added a comment -

        Peter, good point, but it looks like none of the removed Provides are required by Require.

        Show
        Roman Shaposhnik added a comment - Peter, good point, but it looks like none of the removed Provides are required by Require.
        Roman Shaposhnik made changes -
        Field Original Value New Value
        Attachment BIGTOP-781.patch.txt [ 12553541 ]
        Roman Shaposhnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Bruno Mahé added a comment -

        I would rather keep the:

        hive.spec:Provides: %{name}-hbase
        

        It was put in place to make it easier for users (and people like me) to pull the right stuff to have hive/hbase integration being pulled in.
        The rest can be cleaned up as far as I can tell.

        Show
        Bruno Mahé added a comment - I would rather keep the: hive.spec:Provides: %{name}-hbase It was put in place to make it easier for users (and people like me) to pull the right stuff to have hive/hbase integration being pulled in. The rest can be cleaned up as far as I can tell.
        Hide
        Bruno Mahé added a comment -

        Nevermind my last comment. I didn't notice it was about providing what the package names already defines.

        +1 to the patch.
        Nice clean up!

        Show
        Bruno Mahé added a comment - Nevermind my last comment. I didn't notice it was about providing what the package names already defines. +1 to the patch. Nice clean up!
        Hide
        Roman Shaposhnik added a comment -

        Thanks for all the comments and reviews! This is now committed

        Show
        Roman Shaposhnik added a comment - Thanks for all the comments and reviews! This is now committed
        Roman Shaposhnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development