I don't see BIGTOP-738 in the patch attached to this JIRA from Oct 30. That patch uses Lucene directly to manipulate an index, can we include that?
I'll upload a patch for 739 (embedded Solr server) momentarily, assuming my internet doesn't go wonky. That test needs access to SOLR_HOME directory for the example in the stock distro, on my machine for instance it'd be /Users/Erick/apache/4x/solr/example/solr. There's a TODO in the embedded test (739). I notice what looks like setting SOLR_URL as an environment variable, can we do something similar for SOLR_HOME?
I've also uploaded a new patch for 738 that should be in the right package.
But that's really an aside. I guess I'm not sure how far to take creating tests. At this point we've hit a bunch of major units of Solr, although extremely shallowly. My personal feeling is that we should just get this in place then expanding them as needed.
The tests so far are a bit fragile, just something to keep in mind. They use the example installation and manipulate the index there, attempting to clean things up tidily. All well and good, but that makes the state of the index files suspect with more extensive tests. The regular Solr tests have a complicated way of creating temp directories to bypass this problem, but again I think that's for "the future", if we find we need more robustness in the tests. My personal feeling is that we're testing "if everything goes right" here, not "can we handle all the strange cases that could exist".
So lets add the two JIRAs (738 and 739) and I'll close all that series.
Thanks so much for doing the hard parts!