Details

    • Type: Test Test
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.4.0, 0.5.0
    • Fix Version/s: 0.6.0
    • Component/s: tests
    • Labels:
      None

      Description

      Bigtop starts to ship datafu since 0.4 release, we should add its test into the existing integration test suite. I am working on a patch.

      1. BIGTOP-728.txt
        86 kB
        Johnny Zhang

        Activity

        Hide
        Johnny Zhang added a comment -

        I plan to port datafu unit test into iTest. I tried it locally, the major difficult is that datafu unit tests use TestNG, which cannot be invoked (always run 0 tests). I will post a patch soon so that we can discuss how to workaround it.

        Show
        Johnny Zhang added a comment - I plan to port datafu unit test into iTest. I tried it locally, the major difficult is that datafu unit tests use TestNG, which cannot be invoked (always run 0 tests). I will post a patch soon so that we can discuss how to workaround it.
        Hide
        Johnny Zhang added a comment - - edited

        the current patch not really working, one difficult is that datafu depends on pigunit, but Pig project doesn't publish pigunit artifact, so

        <dependency>
          <groupId>org.apache.pig</groupId>
          <artifactId>pigunit</artifactId>
          <version>0.10.0</version>
        </dependency>
        

        doesn't work so far. http://www.slideshare.net/SwissHUG/practical-pig-and-pig-unit-michael-noll-july-2012 page 12
        one way to do it is build pigunit in bigtop, or we have to pull from third party. What do you guys think?

        Show
        Johnny Zhang added a comment - - edited the current patch not really working, one difficult is that datafu depends on pigunit, but Pig project doesn't publish pigunit artifact, so <dependency> <groupId>org.apache.pig</groupId> <artifactId>pigunit</artifactId> <version>0.10.0</version> </dependency> doesn't work so far. http://www.slideshare.net/SwissHUG/practical-pig-and-pig-unit-michael-noll-july-2012 page 12 one way to do it is build pigunit in bigtop, or we have to pull from third party. What do you guys think?
        Hide
        Roman Shaposhnik added a comment -

        Johnny, I think the right thing to do here would be to reach out to the Pig project (opening a JIRA would be a good way) and ask them to start deploying pigunit and pigsmoke as part of their release process. Do you think you can do that?

        Show
        Roman Shaposhnik added a comment - Johnny, I think the right thing to do here would be to reach out to the Pig project (opening a JIRA would be a good way) and ask them to start deploying pigunit and pigsmoke as part of their release process. Do you think you can do that?
        Hide
        Johnny Zhang added a comment -

        Roman, I opened PIG-2988 to ask pigunit maven artifact. For pigsmoke, I think it is a different issue and not needed by datafu test, so haven't open jira for it yet.

        Show
        Johnny Zhang added a comment - Roman, I opened PIG-2988 to ask pigunit maven artifact. For pigsmoke, I think it is a different issue and not needed by datafu test, so haven't open jira for it yet.
        Hide
        Johnny Zhang added a comment -

        PIG-2988 is resovled a while back, and Pig 0.11 starts shipping pigunit maven artifacts

        Show
        Johnny Zhang added a comment - PIG-2988 is resovled a while back, and Pig 0.11 starts shipping pigunit maven artifacts
        Hide
        Roman Shaposhnik added a comment -

        +1 and committed!

        Show
        Roman Shaposhnik added a comment - +1 and committed!

          People

          • Assignee:
            Johnny Zhang
            Reporter:
            Johnny Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development