Bigtop
  1. Bigtop
  2. BIGTOP-504

provide a functionality for detecting libjvm.so in bigtop-utils

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.6.0
    • Component/s: General
    • Labels:
      None

      Description

      Currently, for hdfs fuse we have code lile this in the launcher script:

      if [ "\${LD_LIBRARY_PATH}" = "" ]; then
      export LD_LIBRARY_PATH=/usr/lib
      for f in \`find \${JAVA_HOME}/jre/lib -name client -prune -o -name libjvm.so -exec dirname {} \;\`; do
      export LD_LIBRARY_PATH=\$f:\${LD_LIBRARY_PATH}
      done
      fi
      

      It would be nice to provide this as a general purpose detection code in bigtop-utils.

        Activity

        Hide
        Roman Shaposhnik added a comment -

        +1 and committed!

        Show
        Roman Shaposhnik added a comment - +1 and committed!
        Hide
        Sean Mackrory added a comment -

        I've also made sure this doesn't suffer from any previous problems in bigtop-utils that I'm aware of, such as JAVA_HOME being a symlink.

        Show
        Sean Mackrory added a comment - I've also made sure this doesn't suffer from any previous problems in bigtop-utils that I'm aware of, such as JAVA_HOME being a symlink.
        Hide
        Sean Mackrory added a comment -

        Moved the `find` command into a new script called bigtop-detect-javalibs (similar to bigtop-detect-javahome - which means the invocation will be further simplified if and when we resolve BIGTOP-463).

        I've also made this a bit more flexible so this can also serve for other components that may needed it. Components list the libraries they need to link against dynamically in JAVA_NATIVE_LIBS (in this case just libjvm.so), and the required paths are returned in JAVA_NATIVE_PATH - which can be prepended to LD_LIBRARY_PATH.

        Show
        Sean Mackrory added a comment - Moved the `find` command into a new script called bigtop-detect-javalibs (similar to bigtop-detect-javahome - which means the invocation will be further simplified if and when we resolve BIGTOP-463 ). I've also made this a bit more flexible so this can also serve for other components that may needed it. Components list the libraries they need to link against dynamically in JAVA_NATIVE_LIBS (in this case just libjvm.so), and the required paths are returned in JAVA_NATIVE_PATH - which can be prepended to LD_LIBRARY_PATH.
        Hide
        Bruno Mahé added a comment -

        Sure, go ahead.

        Show
        Bruno Mahé added a comment - Sure, go ahead.
        Hide
        Sean Mackrory added a comment -

        Bruno - I didn't see this JIRA before, and I recently started working on BIGTOP-845 and some other changes to bigtop-utils. Have you already worked on this, or do you mind if I take it over? Just didn't want to step on any toes or duplicate work.

        Show
        Sean Mackrory added a comment - Bruno - I didn't see this JIRA before, and I recently started working on BIGTOP-845 and some other changes to bigtop-utils. Have you already worked on this, or do you mind if I take it over? Just didn't want to step on any toes or duplicate work.

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development