Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: General
    • Labels:
      None

      Description

      When I imported the source, I forgot to remove .gitignore files, so we've got a bunch of them sitting around. I need to prune those out.

      1. gitignore.diff
        0.1 kB
        Andrew Bayer
      2. BIGTOP-3.txt
        3 kB
        Jolly Chen

        Activity

        Hide
        Jolly Chen added a comment -

        Patch submitted.

        Show
        Jolly Chen added a comment - Patch submitted.
        Hide
        Owen O'Malley added a comment -

        Actually, many of the Apache projects have gitignore files because many of the developers use git.apache.org for read-only access to the projects.

        Show
        Owen O'Malley added a comment - Actually, many of the Apache projects have gitignore files because many of the developers use git.apache.org for read-only access to the projects.
        Hide
        Andrew Bayer added a comment -

        Aaaah, good point. I hadn't thought of that. I'll leave this in limbo for a bit while we think about that.

        Show
        Andrew Bayer added a comment - Aaaah, good point. I hadn't thought of that. I'll leave this in limbo for a bit while we think about that.
        Hide
        Andrei Savu added a comment -

        I suggest we keep them. Personally I do all development using git and only commit patches using svn.

        Show
        Andrei Savu added a comment - I suggest we keep them. Personally I do all development using git and only commit patches using svn.
        Hide
        Andrew Bayer added a comment -

        On further examination, the issue is that there are a bunch of .gitignore files strewn around the various rpm-related directories, which don't actually help anything so far as I can tell. I'll add a top level .gitignore, and remove all the superfluous ones.

        Show
        Andrew Bayer added a comment - On further examination, the issue is that there are a bunch of .gitignore files strewn around the various rpm-related directories, which don't actually help anything so far as I can tell. I'll add a top level .gitignore, and remove all the superfluous ones.
        Hide
        Bruno Mahé added a comment - - edited

        a bunch of .gitignore files strewn around the various rpm-related directories, which don't actually help anything so far as I can tell

        The build system was/is/may expect some of these directories to exist. So the .gitignore trick would force the directories to be preserved in git, even if empty. I am not sure if this is still needed though.
        I will take a look, although I suspect this may be needed by rpmbuild itself.

        Show
        Bruno Mahé added a comment - - edited a bunch of .gitignore files strewn around the various rpm-related directories, which don't actually help anything so far as I can tell The build system was/is/may expect some of these directories to exist. So the .gitignore trick would force the directories to be preserved in git, even if empty. I am not sure if this is still needed though. I will take a look, although I suspect this may be needed by rpmbuild itself.
        Hide
        Andrew Bayer added a comment -

        I'm going to leave them be, but I am going to add a top-level .gitignore (and svn:ignore attributes as well).

        Show
        Andrew Bayer added a comment - I'm going to leave them be, but I am going to add a top-level .gitignore (and svn:ignore attributes as well).
        Hide
        Bruno Mahé added a comment -

        +1 for gitignore.diff

        Show
        Bruno Mahé added a comment - +1 for gitignore.diff
        Hide
        Peter Linnell added a comment -

        +1 for gitignore.diff

        svn:ignore sounds fine as well

        Show
        Peter Linnell added a comment - +1 for gitignore.diff svn:ignore sounds fine as well
        Hide
        Andrew Bayer added a comment -

        gitignore committed.

        Show
        Andrew Bayer added a comment - gitignore committed.
        Hide
        Konstantin Boudnik added a comment -

        Looks like it has been committed. Shall the ticket be closed?

        Show
        Konstantin Boudnik added a comment - Looks like it has been committed. Shall the ticket be closed?
        Hide
        Roman Shaposhnik added a comment -

        I'm inclined to close this, even though we still .gitignore all over the place. Thoughts?

        Show
        Roman Shaposhnik added a comment - I'm inclined to close this, even though we still .gitignore all over the place. Thoughts?

          People

          • Assignee:
            Andrew Bayer
            Reporter:
            Andrew Bayer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development