Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.4.0
    • Component/s: General
    • Labels:
      None

      Description

      The packages for jsvc seem to lag behind on Linux distros, it would be nice if Bigtop provided the packages of the latest ones as they are need by Hadoop DN.

      Please note we're not attempting to repackage the JAVA part of the commons daemon project.

      1. BIGTOP-389.patch.txt
        12 kB
        Roman Shaposhnik
      2. BIGTOP-389-2.patch.txt
        13 kB
        Roman Shaposhnik
      3. BIGTOP-389-3.patch.txt
        12 kB
        Roman Shaposhnik
      4. BIGTOP-389-hadoop.patch.txt
        3 kB
        Roman Shaposhnik

        Activity

        Hide
        Roman Shaposhnik added a comment -

        Attaching a trivial packaging for the jsvc part of common daemons. This is not ready for inclusion yet, since we have to resolve the following issues:

        1. I can't seem to be able to regenerate the man pages from the docbook source.
        2. We have to make hadoop depend on a very particular version of jsvc (>=1.0.9 at this point) because of the bugs in prior versions. This eliminates the possibility of using virtual packages since they don't honor versions. Suggestions are welcome here.

        Other than that – please review.

        Show
        Roman Shaposhnik added a comment - Attaching a trivial packaging for the jsvc part of common daemons. This is not ready for inclusion yet, since we have to resolve the following issues: I can't seem to be able to regenerate the man pages from the docbook source. We have to make hadoop depend on a very particular version of jsvc (>=1.0.9 at this point) because of the bugs in prior versions. This eliminates the possibility of using virtual packages since they don't honor versions. Suggestions are welcome here. Other than that – please review.
        Hide
        Roman Shaposhnik added a comment -

        Attaching an updated patch. Things fixed in here:

        1. moved to the latest jsvc 1.0.10
        2. installation location has been changed to where bigtop-utils install
        3. added docs
        4. given that this is NOT replacement for a system-provided jsvc I decided not to include man pages
        Show
        Roman Shaposhnik added a comment - Attaching an updated patch. Things fixed in here: moved to the latest jsvc 1.0.10 installation location has been changed to where bigtop-utils install added docs given that this is NOT replacement for a system-provided jsvc I decided not to include man pages
        Hide
        Peter Linnell added a comment -

        +1 LGTM

        Nitpick: +%define doc_jsvc %{_docdir}/%

        {name}

        << really should be /usr/share/doc/packages on SLES/openSUSE

        Nitpick: add lintian to the build so we can clean up anything else

        Show
        Peter Linnell added a comment - +1 LGTM Nitpick: +%define doc_jsvc %{_docdir}/% {name} << really should be /usr/share/doc/packages on SLES/openSUSE Nitpick: add lintian to the build so we can clean up anything else
        Hide
        Bruno Mahé added a comment -

        I believe %{_docdir} should resolve to the right doc directory.

        Show
        Bruno Mahé added a comment - I believe %{_docdir} should resolve to the right doc directory.
        Hide
        Bruno Mahé added a comment -

        -1

        +# man pages
        +#mkdir -p $MAN_DIR/man1
        +#gzip -c < $DISTRO_DIR/hadoop.1 > $MAN_DIR/man1/hadoop.1.gz
        +#chmod 644 $MAN_DIR/man1/hadoop.1.gz
        

        dead/copy-pasted code should be killed.

        diff --git bigtop-packages/src/deb/bigtop-jsvc/.control.swp bigtop-packages/src/deb/bigtop-jsvc/.control.swp
        

        No need for your swp files

        Show
        Bruno Mahé added a comment - -1 +# man pages +#mkdir -p $MAN_DIR/man1 +#gzip -c < $DISTRO_DIR/hadoop.1 > $MAN_DIR/man1/hadoop.1.gz +#chmod 644 $MAN_DIR/man1/hadoop.1.gz dead/copy-pasted code should be killed. diff --git bigtop-packages/src/deb/bigtop-jsvc/.control.swp bigtop-packages/src/deb/bigtop-jsvc/.control.swp No need for your swp files
        Hide
        Bruno Mahé added a comment -

        See http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Architecture

        +Architecture: i386 amd64 
        

        Why not use "any"? Does it only build on i386 and amd64 exclusively? I would rather keep it open unless it really only builds on i386 and amd64 only.

        Nitpick: Should we follow Fedora guidelines regarding license names? They already have a standardized and consistent set of short names for license: https://fedoraproject.org/wiki/Licensing#Good_Licenses

        +BIGTOP_JSVC_RELNOTES_NAME=Apache Commons Daemon (jsvc)

        I don't think it's being used (yet). But it does not hurt either to keep it.

        Show
        Bruno Mahé added a comment - See http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Architecture +Architecture: i386 amd64 Why not use "any"? Does it only build on i386 and amd64 exclusively? I would rather keep it open unless it really only builds on i386 and amd64 only. Nitpick: Should we follow Fedora guidelines regarding license names? They already have a standardized and consistent set of short names for license: https://fedoraproject.org/wiki/Licensing#Good_Licenses +BIGTOP_JSVC_RELNOTES_NAME=Apache Commons Daemon (jsvc) I don't think it's being used (yet). But it does not hurt either to keep it.
        Hide
        Roman Shaposhnik added a comment -

        Thanks for the feedback. Attached is the last version of the jsvc patch plus a patch that migrates hadoop package onto using it instead of bundling its own.

        Show
        Roman Shaposhnik added a comment - Thanks for the feedback. Attached is the last version of the jsvc patch plus a patch that migrates hadoop package onto using it instead of bundling its own.

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development