Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-3400

Clean up or disable husky installed via packaging Kibana

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0
    • None
    • None

    Description

      Packaging Kibana installs git hooks into Bigtop's .git directory.

      $ ls .git/hooks
      applypatch-msg.sample      post-update.sample     prepare-commit-msg.sample  pre-receive.sample
      commit-msg.sample          pre-applypatch.sample  pre-push.sample            update.sample
      fsmonitor-watchman.sample  pre-commit.sample      pre-rebase.sample
      $ ./gradlew kibana-pkg
      
      (snip)
      
      > husky@0.8.1 install /home/sekikn/repos/bigtop/output/kibana/kibana-5.4.1/node_modules/husky
      > node ./bin/install.js
      
      husky
        setting up hooks in .git/hooks/
        done
      
      (snip)
      
      BUILD SUCCESSFUL in 15m 44s
      $ ls .git/hooks
      applypatch-msg.sample      post-rewrite           pre-commit.sample          pre-rebase
      commit-msg.sample          post-update.sample     prepare-commit-msg.sample  pre-rebase.sample
      fsmonitor-watchman.sample  pre-applypatch.sample  pre-push                   pre-receive.sample
      post-merge                 pre-commit             pre-push.sample            update.sample
      

      But it doesn't work as expected once the output/kibana directory is cleaned.

      $ ./gradlew kibana-clean
      $ git pull origin master 
      From https://github.com/sekikn/bigtop
       * branch              master     -> FETCH_HEAD
      Already up to date.
      $ git push origin master 
      .git/hooks/pre-push: 4: cd: can't cd to output/kibana/kibana-5.4.1
      

      These hooks are not intentionally installed, so I think they should be removed when the build is finished, or disabled from the beginning.

      Attachments

        Activity

          People

            sekikn Kengo Seki
            sekikn Kengo Seki
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h