[BIGTOP-3160] [Provisioner] Treat both exit code 0 and 2 as success for Puppet execution

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.4.0
• Component/s: provisioner
• Assignee: Evans Ye
• Reporter: Evans Ye
• Created: 12/Feb/19 06:33
• Updated: 18/Mar/19 15:41
• Resolved: 13/Feb/19 09:29

Description

With BIGTOP-3150, when exit code != 0, we'll raise a failure. However both exit code 0 and 2 are success executions. See the doc:

0: The run succeeded with no changes or failures; the system was already in the desired state.

1: The run failed, or wasn't attempted due to another run already in progress.

2: The run succeeded, and some resources were changed.

4: The run succeeded, and some resources failed.

6: The run succeeded, and included both changes and failures.

Ref: https://puppet.com/docs/puppet/5.4/man/agent.html

Issue Links

• relates to: BIGTOP-3150 [Provisioner] Raise proper exit code and error messages when provisioning failed
• links to: GitHub Pull Request #466