Bigtop
  1. Bigtop
  2. BIGTOP-292

Bigtop SRPMs and SDEBs can not be rebuilt

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 0.2.0, 0.8.0
    • Fix Version/s: None
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      Quite a few packages (Hadoop being the most prominent examples) fail to mention all of the files from common they depdend upon during the build/install phase of SPRM -> RPM.

      The dump approach to fixing this is to list all of the missing files explicitly. However, perhaps we should really create a tarball with all the source dependencies and have that as a single extra Source1 tag

      Please chime in with your thoughts.

        Activity

        Hide
        Andrew Bayer added a comment -

        I'd be fine with a tarball of everything but do-component-build and install_*.sh - those are the only ones that are truly consistent across all components, and are guaranteed to be there across all components (except for bigtop-utils, but that's a special case).

        Show
        Andrew Bayer added a comment - I'd be fine with a tarball of everything but do-component-build and install_*.sh - those are the only ones that are truly consistent across all components, and are guaranteed to be there across all components (except for bigtop-utils, but that's a special case).
        Hide
        Peter Linnell added a comment -

        Yes, without looking at the particulars is to have an extra tarball with all the needed bits. Which then raises the question: How difficult to create and maintain long term.

        Show
        Peter Linnell added a comment - Yes, without looking at the particulars is to have an extra tarball with all the needed bits. Which then raises the question: How difficult to create and maintain long term.
        Hide
        Bruno Mahé added a comment -

        I would rather avoid a separate tarball with extra files. It would make rebuilding packages harder and error prone.
        For instance, if I want to modify some of the init scripts, I would have to expand that tarball, edit it, and rebuild that tarball every time.

        Listing all the files maybe tedious initially, but that list will not change that often, and it will enable us to take advantage of rpm/dpkg features, such as checking all the files needed are there and no extra files will be included.

        I can take care of this ticket by the end of this week.

        Show
        Bruno Mahé added a comment - I would rather avoid a separate tarball with extra files. It would make rebuilding packages harder and error prone. For instance, if I want to modify some of the init scripts, I would have to expand that tarball, edit it, and rebuild that tarball every time. Listing all the files maybe tedious initially, but that list will not change that often, and it will enable us to take advantage of rpm/dpkg features, such as checking all the files needed are there and no extra files will be included. I can take care of this ticket by the end of this week.
        Hide
        Andrew Bayer added a comment -

        Ok, that seems reasonable to me.

        Show
        Andrew Bayer added a comment - Ok, that seems reasonable to me.
        Hide
        Roman Shaposhnik added a comment -

        Pushing to 0.4

        Show
        Roman Shaposhnik added a comment - Pushing to 0.4
        Hide
        Olaf Flebbe added a comment -

        I noticed this, too (for debian).

        I did already some ground work on this. Will dig out some patches for a start.

        Show
        Olaf Flebbe added a comment - I noticed this, too (for debian). I did already some ground work on this. Will dig out some patches for a start.

          People

          • Assignee:
            Olaf Flebbe
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development