Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.2.1, 1.3.0
    • Fix Version/s: 1.2.1, 1.3.0
    • Component/s: build
    • Labels:
      None

      Description

      Konstantin Boudnik reported a RAT failure with the giraph charm when reviewing 1.2.1 readiness:

      • RAT (failed)
        The release tarball includes a binary file [1]. If the file is definetely
        should be a part of the release (which I have my reservations as this goes
        against source-only policy of the ASF), then at the very least we need to
        add it into RAT exclue list.

      [1] bigtop-packages/src/charm/giraph/layer-giraph/resources/giraph-examples-1.1.0.jar

      I happen to know that panagiotisl packed this examples.jar into the charm source because it does not exist on the system by default.

      Upon further inspection, it seems this jar is available in the giraph-doc package. I think a simple fix will be to install this package during charm install so we can use the system jar and remove the binary from this source tree.

      I'll open an issue on the giraph charm repo and link it here shortly.

      1. BIGTOP-2908.patch
        152 kB
        Kevin W Monroe

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          I've committed this in branch 1.2. This JIRA is fixed in 1.2.1 and 1.3.0.

          Show
          evans_ye Evans Ye added a comment - I've committed this in branch 1.2. This JIRA is fixed in 1.2.1 and 1.3.0.
          Hide
          evans_ye Evans Ye added a comment -

          Looks good. I'll commit for 1.2 branch. Thanks Kevin.

          Show
          evans_ye Evans Ye added a comment - Looks good. I'll commit for 1.2 branch. Thanks Kevin.
          Hide
          kwmonroe Kevin W Monroe added a comment -

          Evans Ye, I've committed the attached patch to master:

          https://github.com/apache/bigtop/commit/08aa3a267aff2605a06e27c23368e5c17115b122

          As the RM of 1.2.1, I'd like your +1 to commit to branch-1.2 as well (or feel free to commit there yourself if you want).

          Show
          kwmonroe Kevin W Monroe added a comment - Evans Ye , I've committed the attached patch to master: https://github.com/apache/bigtop/commit/08aa3a267aff2605a06e27c23368e5c17115b122 As the RM of 1.2.1, I'd like your +1 to commit to branch-1.2 as well (or feel free to commit there yourself if you want).
          Hide
          kwmonroe Kevin W Monroe added a comment -

          New giraph charm based on the attached patch deploys and smoke-tests cleanly.

          The only usage of the embeded giraph-examples.jar was when setting GIRAPH_JARS in /etc/environment. With the attached patch, we now install giraph-doc and use the jar from the filesystem. We can see this looks good in the new giraph unit's /etc/environment:

          ...
          GIRAPH_JARS="/usr/share/doc/giraph/giraph-examples-1.1.0.jar,/usr/lib/giraph/...
          ...
          
          Show
          kwmonroe Kevin W Monroe added a comment - New giraph charm based on the attached patch deploys and smoke-tests cleanly. The only usage of the embeded giraph-examples.jar was when setting GIRAPH_JARS in /etc/environment. With the attached patch, we now install giraph-doc and use the jar from the filesystem. We can see this looks good in the new giraph unit's /etc/environment: ... GIRAPH_JARS="/usr/share/doc/giraph/giraph-examples-1.1.0.jar,/usr/lib/giraph/... ...
          Hide
          cos Konstantin Boudnik added a comment -

          Thanks Kevin! In the interest of full disclosure, we have another jar file that gets included in our releases [1], but internally it is just a set of test files used for tests. As such it could be easily validated for license cleanness.

          [1] bigtop-tests/test-artifacts/hadoop/src/main/resources/cachedir.jar

          Show
          cos Konstantin Boudnik added a comment - Thanks Kevin! In the interest of full disclosure, we have another jar file that gets included in our releases [1] , but internally it is just a set of test files used for tests. As such it could be easily validated for license cleanness. [1] bigtop-tests/test-artifacts/hadoop/src/main/resources/cachedir.jar

            People

            • Assignee:
              kwmonroe Kevin W Monroe
              Reporter:
              kwmonroe Kevin W Monroe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development