Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.1
    • Component/s: build
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user tweise closed the pull request at:

        https://github.com/apache/bigtop/pull/219

        Show
        githubbot ASF GitHub Bot added a comment - Github user tweise closed the pull request at: https://github.com/apache/bigtop/pull/219
        Hide
        asl Arnaud Launay added a comment -

        Here it is : BIGTOP-2788

        Show
        asl Arnaud Launay added a comment - Here it is : BIGTOP-2788
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user alaunay closed the pull request at:

        https://github.com/apache/bigtop/pull/223

        Show
        githubbot ASF GitHub Bot added a comment - Github user alaunay closed the pull request at: https://github.com/apache/bigtop/pull/223
        Hide
        asl Arnaud Launay added a comment -

        No problem, I'll do it. I'll learn how to rename a git branch

        Show
        asl Arnaud Launay added a comment - No problem, I'll do it. I'll learn how to rename a git branch
        Hide
        evans_ye Evans Ye added a comment -

        Better to create a new one because I've already committed this
        It should be fairly easy to do so:

        • Just create a new JIRA with a new title
        • Amend the commit message of the patch to align new JIRA title
        • Create a PR with the title align new JIRA tile

        If you guys don't have time, I can do the trick for you.

        Show
        evans_ye Evans Ye added a comment - Better to create a new one because I've already committed this It should be fairly easy to do so: Just create a new JIRA with a new title Amend the commit message of the patch to align new JIRA title Create a PR with the title align new JIRA tile If you guys don't have time, I can do the trick for you.
        Hide
        thw Thomas Weise added a comment -

        Evans Ye how about reassigning this issue to Arnaud Launay given he fixed it?

        Show
        thw Thomas Weise added a comment - Evans Ye how about reassigning this issue to Arnaud Launay given he fixed it?
        Hide
        evans_ye Evans Ye added a comment -

        Hi Arnaud Launay thanks for the patch.
        Can you create another JIRA and attach your PR to that JIRA with the updated commit message? That way we can better track the changes and give author proper credits.

        BTW, I've tested this on opensuse, fedora, ubuntu, the patch is good, +1.

        Thomas Weise
        We've instructions here https://cwiki.apache.org/confluence/display/BIGTOP/How+to+build+Bigtop-trunk
        Theoretically, testing over all the OS is more thoroughly, but in practice, I'll only choose one RPM and one DEB to when doing manually test, and let CI do the full evaluation. Is this what you're asking?

        Show
        evans_ye Evans Ye added a comment - Hi Arnaud Launay thanks for the patch. Can you create another JIRA and attach your PR to that JIRA with the updated commit message? That way we can better track the changes and give author proper credits. BTW, I've tested this on opensuse, fedora, ubuntu, the patch is good, +1. Thomas Weise We've instructions here https://cwiki.apache.org/confluence/display/BIGTOP/How+to+build+Bigtop-trunk Theoretically, testing over all the OS is more thoroughly, but in practice, I'll only choose one RPM and one DEB to when doing manually test, and let CI do the full evaluation. Is this what you're asking?
        Hide
        thw Thomas Weise added a comment - - edited

        Arnaud Launay thanks for updating the patch. It was a bit optimistic for me to just rely on the CI result.

        Roman Shaposhnik I'm looking into putting together some instructions for maintaining the Apex component so others also know what to do. Is there a recommended docker image for a bigtop build environment?

        Show
        thw Thomas Weise added a comment - - edited Arnaud Launay thanks for updating the patch. It was a bit optimistic for me to just rely on the CI result. Roman Shaposhnik I'm looking into putting together some instructions for maintaining the Apex component so others also know what to do. Is there a recommended docker image for a bigtop build environment?
        Hide
        asl Arnaud Launay added a comment -

        It's just an update of a previously existing patch, and it just bumps the line references (the files the patch modifies had been modified upstream, and thus the previous patch doesn't apply)

        BTW, you can disregard the attachment (I'm deleting it just after posting that)

        Err, the answer to the question is thus: "yes"

        Show
        asl Arnaud Launay added a comment - It's just an update of a previously existing patch, and it just bumps the line references (the files the patch modifies had been modified upstream, and thus the previous patch doesn't apply) BTW, you can disregard the attachment (I'm deleting it just after posting that) Err, the answer to the question is thus: "yes"
        Hide
        rvs Roman Shaposhnik added a comment -

        Arnaud Launay OK, I'm confused: are you saying your patch is needed on top of what Thomas Weise provided?

        Show
        rvs Roman Shaposhnik added a comment - Arnaud Launay OK, I'm confused: are you saying your patch is needed on top of what Thomas Weise provided?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user alaunay opened a pull request:

        https://github.com/apache/bigtop/pull/223

        BIGTOP-2776: corrects patch for Bump Apache Apex version to 3.6.0

        This updates the apex patch up to the new version

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/alaunay/bigtop BIGTOP-2776

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/223.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #223


        commit 71477ca33375b351f97ca09a31a72a32eb42320e
        Author: Arnaud Launay <asl-github@launay.org>
        Date: 2017-05-28T00:34:54Z

        BIGTOP-2776: corrects patch for Bump Apache Apex version to 3.6.0


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user alaunay opened a pull request: https://github.com/apache/bigtop/pull/223 BIGTOP-2776 : corrects patch for Bump Apache Apex version to 3.6.0 This updates the apex patch up to the new version You can merge this pull request into a Git repository by running: $ git pull https://github.com/alaunay/bigtop BIGTOP-2776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 71477ca33375b351f97ca09a31a72a32eb42320e Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-28T00:34:54Z BIGTOP-2776 : corrects patch for Bump Apache Apex version to 3.6.0
        Hide
        asl Arnaud Launay added a comment -

        Patch attached, I think I killed my github repo

        Show
        asl Arnaud Launay added a comment - Patch attached, I think I killed my github repo
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user alaunay closed the pull request at:

        https://github.com/apache/bigtop/pull/222

        Show
        githubbot ASF GitHub Bot added a comment - Github user alaunay closed the pull request at: https://github.com/apache/bigtop/pull/222
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user alaunay commented on the issue:

        https://github.com/apache/bigtop/pull/222

        sorry, again a bad one, still having trouble with git

        Show
        githubbot ASF GitHub Bot added a comment - Github user alaunay commented on the issue: https://github.com/apache/bigtop/pull/222 sorry, again a bad one, still having trouble with git
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user alaunay opened a pull request:

        https://github.com/apache/bigtop/pull/222

        BIGTOP-2776: corrects patch for Bump Apache Apex version to 3.6.0

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/alaunay/bigtop BIGTOP-2776

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/222.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #222


        commit d88cc0db0ea4172d4732c96404ba40fc9307ed8d
        Author: Arnaud Launay <asl-github@launay.org>
        Date: 2017-05-27T19:27:20Z

        BIGTOP-2778: Delete PermSize / MaxPermsize options, no longer support by Java 8

        commit 4f7a7a46d05898f318b9b70e77df0824604a44fc
        Author: Arnaud Launay <asl-github@launay.org>
        Date: 2017-05-27T19:30:16Z

        revert b7f8b9d0aadbd2f839b2b55efcde912709e0553a: bad branch

        commit d9b1ccae92afb37906f2d59ca13a23a6c1d9bef2
        Author: Arnaud Launay <asl-github@launay.org>
        Date: 2017-05-27T21:47:46Z

        BIGTOP-2776: corrects patch for Bump Apache Apex version to 3.6.0


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user alaunay opened a pull request: https://github.com/apache/bigtop/pull/222 BIGTOP-2776 : corrects patch for Bump Apache Apex version to 3.6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/alaunay/bigtop BIGTOP-2776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit d88cc0db0ea4172d4732c96404ba40fc9307ed8d Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-27T19:27:20Z BIGTOP-2778 : Delete PermSize / MaxPermsize options, no longer support by Java 8 commit 4f7a7a46d05898f318b9b70e77df0824604a44fc Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-27T19:30:16Z revert b7f8b9d0aadbd2f839b2b55efcde912709e0553a: bad branch commit d9b1ccae92afb37906f2d59ca13a23a6c1d9bef2 Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-27T21:47:46Z BIGTOP-2776 : corrects patch for Bump Apache Apex version to 3.6.0
        Hide
        asl Arnaud Launay added a comment -

        Hmmm, apparently this has been committed, but breaks compilation under Debian 8:

        {{
        dpkg-source -b apex-3.6.0
        dpkg-source: info: using source format `3.0 (quilt)'
        dpkg-source: info: building apex using existing ./apex_3.6.0.orig.tar.gz
        patching file engine/src/main/java/com/datatorrent/stram/client/StramAppLauncher.java
        Hunk #1 succeeded at 584 (offset 1 line).
        patching file engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java
        Hunk #1 FAILED at 156.
        1 out of 1 hunk FAILED
        dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
        dpkg-source: info: if patch 'patch1-for-hadoop27x.diff' is correctly applied by quilt, use 'quilt refresh' to update it
        dpkg-source: error: LC_ALL=C patch t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/patch1-for-hadoop27x.diff/ --reject-file= < apex-3.6.0.orig.w9m2l9/debian/patches/patch1-for-hadoop27x.diff gave error exit status 1
        dpkg-buildpackage: error: dpkg-source -b apex-3.6.0 gave error exit status 2
        :apex-sdeb FAILED
        }}

        Show
        asl Arnaud Launay added a comment - Hmmm, apparently this has been committed, but breaks compilation under Debian 8: {{ dpkg-source -b apex-3.6.0 dpkg-source: info: using source format `3.0 (quilt)' dpkg-source: info: building apex using existing ./apex_3.6.0.orig.tar.gz patching file engine/src/main/java/com/datatorrent/stram/client/StramAppLauncher.java Hunk #1 succeeded at 584 (offset 1 line). patching file engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java Hunk #1 FAILED at 156. 1 out of 1 hunk FAILED dpkg-source: info: the patch has fuzz which is not allowed, or is malformed dpkg-source: info: if patch 'patch1-for-hadoop27x.diff' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: LC_ALL=C patch t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/patch1-for-hadoop27x.diff/ --reject-file= < apex-3.6.0.orig.w9m2l9/debian/patches/patch1-for-hadoop27x.diff gave error exit status 1 dpkg-buildpackage: error: dpkg-source -b apex-3.6.0 gave error exit status 2 :apex-sdeb FAILED }}
        Hide
        evans_ye Evans Ye added a comment -

        LGTM, +1
        Let's let CI try the build.

        Show
        evans_ye Evans Ye added a comment - LGTM, +1 Let's let CI try the build.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user tweise commented on the issue:

        https://github.com/apache/bigtop/pull/219

        @rvs please have a look
        CC: @chinmaykolhatkar

        Show
        githubbot ASF GitHub Bot added a comment - Github user tweise commented on the issue: https://github.com/apache/bigtop/pull/219 @rvs please have a look CC: @chinmaykolhatkar
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user tweise opened a pull request:

        https://github.com/apache/bigtop/pull/219

        BIGTOP-2776: Upgrade Apache Apex to 3.6.0

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/tweise/bigtop BIGTOP-2776

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/219.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #219


        commit bfb32ff531e44379a81dee75960a3cdc0a65374d
        Author: Thomas Weise <thw@apache.org>
        Date: 2017-05-26T10:50:32Z

        BIGTOP-2776: Upgrade Apache Apex to 3.6.0


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user tweise opened a pull request: https://github.com/apache/bigtop/pull/219 BIGTOP-2776 : Upgrade Apache Apex to 3.6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tweise/bigtop BIGTOP-2776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #219 commit bfb32ff531e44379a81dee75960a3cdc0a65374d Author: Thomas Weise <thw@apache.org> Date: 2017-05-26T10:50:32Z BIGTOP-2776 : Upgrade Apache Apex to 3.6.0

          People

          • Assignee:
            thw Thomas Weise
            Reporter:
            thw Thomas Weise
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development