Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2774

gradlew toolchain does not work on Ubuntu 16.04.2/Puppet 3.8.5

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1
    • Component/s: toolchain
    • Labels:
      None
    • Environment:

      Ubuntu 16.04.2, Puppet 3.8.5

      Description

      After installing devtools and puppetmodules, I ran gradlew toolchain on newly installed machine and got the following error:

      $ ./gradlew toolchain
      
      (snip)
      
      Error: Syntax error at 'Hash'; expected ')' at /etc/puppet/modules/apt/manifests/init.pp:6 on node ubuntu
      Error: Syntax error at 'Hash'; expected ')' at /etc/puppet/modules/apt/manifests/init.pp:6 on node ubuntu
      :toolchain FAILED
      

      This is solved by adding --parser future option to puppet apply command, but another error also occurred:

      Error: Evaluation Error: Error while evaluating a Function Call, Must pass update_defaults to Class[Apt] at /home/sekikn/bigtop/bigtop_toolchain/manifests/jdk.pp:29:7 on node ubuntu
      Error: Evaluation Error: Error while evaluating a Function Call, Must pass update_defaults to Class[Apt] at /home/sekikn/bigtop/bigtop_toolchain/manifests/jdk.pp:29:7 on node ubuntu
      

      It seems to be caused by puppetlabs-apt 3.0.0 and 4.0.0, which are recently released. Actually, their changelog says as follows:

      If you're still running Puppet 3, remain on the latest puppetlabs-apt 2.x release for now, and see the documentation to upgrade to Puppet 4.

        Issue Links

          Activity

          Hide
          sekikn Kengo Seki added a comment -

          Thanks for the comment and review Arnaud Launay Konstantin Boudnik Evans Ye. I think we can remove version checking in puppet-modules.pp once we've totally moved to puppet 4.
          Committed and pushed to the master.

          Show
          sekikn Kengo Seki added a comment - Thanks for the comment and review Arnaud Launay Konstantin Boudnik Evans Ye . I think we can remove version checking in puppet-modules.pp once we've totally moved to puppet 4. Committed and pushed to the master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/214

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/214
          Hide
          evans_ye Evans Ye added a comment -

          LGTM as well. +1 and thanks!

          Show
          evans_ye Evans Ye added a comment - LGTM as well. +1 and thanks!
          Hide
          cos Konstantin Boudnik added a comment -

          This is still a bug and its nice to get it fixed. The patch looks good, BTW (I haven't tested it though). Thanks!

          Show
          cos Konstantin Boudnik added a comment - This is still a bug and its nice to get it fixed. The patch looks good, BTW (I haven't tested it though). Thanks!
          Hide
          asl Arnaud Launay added a comment -

          Hello Kengo,

          I think this is more or less wanted.

          https://issues.apache.org/jira/browse/BIGTOP-2746

          States that bigtop should support puppet 4.

          There was a micro topic on the list:

          http://mail-archives.apache.org/mod_mbox/bigtop-dev/201704.mbox/%3CCAJ-3c%2Bjb5DCN1XegdeU0Tj_cX81ewnUtAs5OsyZLPOUYaqazwQ%40mail.gmail.com%3E

          No word about /not/ supporting puppet 3 anymore, though.

          Show
          asl Arnaud Launay added a comment - Hello Kengo, I think this is more or less wanted. https://issues.apache.org/jira/browse/BIGTOP-2746 States that bigtop should support puppet 4. There was a micro topic on the list: http://mail-archives.apache.org/mod_mbox/bigtop-dev/201704.mbox/%3CCAJ-3c%2Bjb5DCN1XegdeU0Tj_cX81ewnUtAs5OsyZLPOUYaqazwQ%40mail.gmail.com%3E No word about /not/ supporting puppet 3 anymore, though.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sekikn opened a pull request:

          https://github.com/apache/bigtop/pull/214

          BIGTOP-2774. gradlew toolchain does not work on Ubuntu 16.04.2/Puppet 3.8.5

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sekikn/bigtop BIGTOP-2774

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/214.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #214


          commit 69b1c6361260aa857e5e736d81d550c643916251
          Author: Kengo Seki <sekikn@apache.org>
          Date: 2017-05-23T15:27:37Z

          BIGTOP-2774. gradlew toolchain does not work on Ubuntu 16.04.2/Puppet 3.8.5


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sekikn opened a pull request: https://github.com/apache/bigtop/pull/214 BIGTOP-2774 . gradlew toolchain does not work on Ubuntu 16.04.2/Puppet 3.8.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sekikn/bigtop BIGTOP-2774 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit 69b1c6361260aa857e5e736d81d550c643916251 Author: Kengo Seki <sekikn@apache.org> Date: 2017-05-23T15:27:37Z BIGTOP-2774 . gradlew toolchain does not work on Ubuntu 16.04.2/Puppet 3.8.5

            People

            • Assignee:
              sekikn Kengo Seki
              Reporter:
              sekikn Kengo Seki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development