Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2729

AMBARI-20686: Add ID to allow compilation with recent maven

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1
    • Component/s: build, debian
    • Labels:
      None
    • Environment:

      Description

      [INFO] Reading assembly descriptor: src/main/assemblies/odpi-ambari-mpack.xml
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD FAILURE
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 1.138 s
      [INFO] Finished at: 2017-03-31T15:34:51+02:00
      [INFO] Final Memory: 13M/292M
      [INFO] ------------------------------------------------------------------------
      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4.1:single (build-tarball) on project odpi-ambari-mpack: Assembly is incorrectly configured: Assembly is incorrectly configured:
      [ERROR] Assembly: is not configured correctly: Assembly ID must be present and non-empty.

      1. BIGTOP-2729.1.patch
        2 kB
        Olaf Flebbe
      2. mvn-depresolv.txt
        31 kB
        Arnaud Launay
      3. odpi-eX.txt
        54 kB
        Arnaud Launay

        Issue Links

          Activity

          Hide
          asl Arnaud Launay added a comment -

          $ cd /tmp/bigtop-1.2.0/output/ambari/ambari-2.5.0/contrib/management-packs/odpi-ambari-mpack
          $ mvn package -e -X | tee -a /tmp/odpi-eX.txt
          (...)
          [INFO] BUILD FAILURE
          (...)

          results in the log attached.

          $ mvn -version
          Apache Maven 3.3.9
          Maven home: /usr/share/maven
          Java version: 1.8.0_121, vendor: Oracle Corporation
          Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
          Default locale: en_US, platform encoding: ANSI_X3.4-1968
          OS name: "linux", version: "3.16.0-4-amd64", arch: "amd64", family: "unix"

          Show
          asl Arnaud Launay added a comment - $ cd /tmp/bigtop-1.2.0/output/ambari/ambari-2.5.0/contrib/management-packs/odpi-ambari-mpack $ mvn package -e -X | tee -a /tmp/odpi-eX.txt (...) [INFO] BUILD FAILURE (...) results in the log attached. $ mvn -version Apache Maven 3.3.9 Maven home: /usr/share/maven Java version: 1.8.0_121, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux", version: "3.16.0-4-amd64", arch: "amd64", family: "unix"
          Hide
          rvs Roman Shaposhnik added a comment -

          Ok, the mystery is solved. This is related to the version of the maven-assembly-plugin which in our case is 2.2-beta-5 and in your case it is 2.4.1. Now, given that we're running exactly the same versions of Maven – why a different version of maven-dependency-plugin is being pulled is baffling to me. Can you please run mvn dependency:resolve-plugins and attach the results?

          Show
          rvs Roman Shaposhnik added a comment - Ok, the mystery is solved. This is related to the version of the maven-assembly-plugin which in our case is 2.2-beta-5 and in your case it is 2.4.1. Now, given that we're running exactly the same versions of Maven – why a different version of maven-dependency-plugin is being pulled is baffling to me. Can you please run mvn dependency:resolve-plugins and attach the results?
          Hide
          asl Arnaud Launay added a comment -

          mvn dependency:resolve-plugins

          output

          Show
          asl Arnaud Launay added a comment - mvn dependency:resolve-plugins output
          Hide
          asl Arnaud Launay added a comment -

          Any idea ? I'm willing to do any test necessary

          Show
          asl Arnaud Launay added a comment - Any idea ? I'm willing to do any test necessary
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user alaunay opened a pull request:

          https://github.com/apache/ambari/pull/52

          Add ID to allow maven >=2.2 validation

          According to:

          https://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers

          The ID is mandatory since maven >=2.2 , and worked only without it before due to a bug.

          Concerns BIGTOP-2729

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alaunay/ambari trunk

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/ambari/pull/52.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #52


          commit 72e5c152c0e8b89b980dae3cf53004d1b8f836b6
          Author: Arnaud Launay <alaunay@cusae.com>
          Date: 2017-04-05T10:53:03Z

          Add ID to allow maven >=2.2 validation


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user alaunay opened a pull request: https://github.com/apache/ambari/pull/52 Add ID to allow maven >=2.2 validation According to: https://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers The ID is mandatory since maven >=2.2 , and worked only without it before due to a bug. Concerns BIGTOP-2729 You can merge this pull request into a Git repository by running: $ git pull https://github.com/alaunay/ambari trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ambari/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 72e5c152c0e8b89b980dae3cf53004d1b8f836b6 Author: Arnaud Launay <alaunay@cusae.com> Date: 2017-04-05T10:53:03Z Add ID to allow maven >=2.2 validation
          Hide
          rvs Roman Shaposhnik added a comment -

          Arnaud Launay I think I finally figured out the last missing bit of the puzzle. You're absolutely correct that this needs to be fixed, but the reason it builds for me (and for Bigtop's Docker containers) is that contrib pom.xml doesn't specify the version of the assembly plugin explicitly. Which means that whatever version gets downloaded first is used.

          Now, here's where it gets interesting – since we build empty .m2 in our setup we always force 2.2-beta-5 beta simply because the top level POM of Ambari actually demands that version. If, however, you're building just the contrib and have newer version of the plugin – everything breaks.

          All in all, I don't think it was a blocker for the 1.2.0 release. In fact, as you rightfully pointed out – it isn't even Bigtop's issue – it is an Ambari issue.

          With that in mind, could you please file an Ambari JIRA and submit your patch there?

          I can then re-use this JIRA to forward port the Ambari patch into bigtop's master branch.

          Sounds good?

          Show
          rvs Roman Shaposhnik added a comment - Arnaud Launay I think I finally figured out the last missing bit of the puzzle. You're absolutely correct that this needs to be fixed, but the reason it builds for me (and for Bigtop's Docker containers) is that contrib pom.xml doesn't specify the version of the assembly plugin explicitly. Which means that whatever version gets downloaded first is used. Now, here's where it gets interesting – since we build empty .m2 in our setup we always force 2.2-beta-5 beta simply because the top level POM of Ambari actually demands that version. If, however, you're building just the contrib and have newer version of the plugin – everything breaks. All in all, I don't think it was a blocker for the 1.2.0 release. In fact, as you rightfully pointed out – it isn't even Bigtop's issue – it is an Ambari issue. With that in mind, could you please file an Ambari JIRA and submit your patch there? I can then re-use this JIRA to forward port the Ambari patch into bigtop's master branch. Sounds good?
          Hide
          asl Arnaud Launay added a comment -

          The pull request was directed at ambari, do I need to create an issue in its own jira ?

          Concerning BigTop, may we agree on adding a patch via do-component-build ? There are already quite a few used (hive, giraph, etc), and it would lead to ambari 2.5.0 compiling with bigtop 1.2.0. Small patch, big effect

          Show
          asl Arnaud Launay added a comment - The pull request was directed at ambari, do I need to create an issue in its own jira ? Concerning BigTop, may we agree on adding a patch via do-component-build ? There are already quite a few used (hive, giraph, etc), and it would lead to ambari 2.5.0 compiling with bigtop 1.2.0. Small patch, big effect
          Hide
          rvs Roman Shaposhnik added a comment -

          Arnaud Launay yup that's what I meant – please create a separate JIRA for AMBARI project and link to your pull request.

          I totally agree that patching at the Bigtop level makes perfect sense – but I'd rather do it with the commit from the Ambari tree (hence the need for an Ambari JIRA and their agreement to pull it into the tree).

          One you file a JIRA and link your pull request – I can ping a few folks on the Ambari community I know to ask for a prompt review.

          Show
          rvs Roman Shaposhnik added a comment - Arnaud Launay yup that's what I meant – please create a separate JIRA for AMBARI project and link to your pull request. I totally agree that patching at the Bigtop level makes perfect sense – but I'd rather do it with the commit from the Ambari tree (hence the need for an Ambari JIRA and their agreement to pull it into the tree). One you file a JIRA and link your pull request – I can ping a few folks on the Ambari community I know to ask for a prompt review.
          Hide
          asl Arnaud Launay added a comment -

          Here it is: AMBARI-20686

          Show
          asl Arnaud Launay added a comment - Here it is: AMBARI-20686
          Hide
          oflebbe Olaf Flebbe added a comment -

          Thanks for your patch in github pull request. I tweaked it a bit to support RPM's as well

          Show
          oflebbe Olaf Flebbe added a comment - Thanks for your patch in github pull request. I tweaked it a bit to support RPM's as well
          Hide
          asl Arnaud Launay added a comment - - edited

          Could this be commited ? It still prevents the compilation, and the patch has been accepted upstream (for 2.5.2).

          Show
          asl Arnaud Launay added a comment - - edited Could this be commited ? It still prevents the compilation, and the patch has been accepted upstream (for 2.5.2).
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user alaunay opened a pull request:

          https://github.com/apache/bigtop/pull/220

          BIGTOP-2729: AMBARI-20686: Add ID to allow compilation with recent maven

          Git push with Olaf's redhat modifications.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alaunay/bigtop BIGTOP-2729

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/220.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #220


          commit 38bffd9aa84a611309be7728419a475837da8002
          Author: Arnaud Launay <asl-github@launay.org>
          Date: 2017-05-26T20:52:05Z

          BIGTOP-2729: AMBARI-20686: Add ID to allow compilation with recent maven


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user alaunay opened a pull request: https://github.com/apache/bigtop/pull/220 BIGTOP-2729 : AMBARI-20686 : Add ID to allow compilation with recent maven Git push with Olaf's redhat modifications. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alaunay/bigtop BIGTOP-2729 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #220 commit 38bffd9aa84a611309be7728419a475837da8002 Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-26T20:52:05Z BIGTOP-2729 : AMBARI-20686 : Add ID to allow compilation with recent maven
          Hide
          evans_ye Evans Ye added a comment -

          LGTM, +1

          Show
          evans_ye Evans Ye added a comment - LGTM, +1
          Hide
          evans_ye Evans Ye added a comment -

          Committed. Thanks for your patch Arnaud Launay.

          Show
          evans_ye Evans Ye added a comment - Committed. Thanks for your patch Arnaud Launay .
          Hide
          asl Arnaud Launay added a comment -

          Credits where it's due, Olaf Flebbe did the redhat work.

          Show
          asl Arnaud Launay added a comment - Credits where it's due, Olaf Flebbe did the redhat work.
          Hide
          evans_ye Evans Ye added a comment -

          Indeed, thanks Olaf Flebbe.

          Show
          evans_ye Evans Ye added a comment - Indeed, thanks Olaf Flebbe .
          Hide
          oflebbe Olaf Flebbe added a comment -

          Arnaud Launay thank you for providing the initial patch.

          Show
          oflebbe Olaf Flebbe added a comment - Arnaud Launay thank you for providing the initial patch.
          Hide
          asl Arnaud Launay added a comment -

          Maybe we can declare the thanks period over :-D

          Not for this one, but is there a way to have multiple authors on "one" commit ?

          Show
          asl Arnaud Launay added a comment - Maybe we can declare the thanks period over :-D Not for this one, but is there a way to have multiple authors on "one" commit ?

            People

            • Assignee:
              asl Arnaud Launay
              Reporter:
              asl Arnaud Launay
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development