Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2549

"Expected" and "actual" values are mistakenly switched in some JUnit method invocation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Description

      I ran hdfs smoke test, and got the following result:

      org.apache.bigtop.itest.hadoop.hdfs.TestTextSnappy > testTextSnappy STANDARD_OUT
          hadoop fs -text testtextsnappy.1475725399538/part-00001.snappy
          Failed command: hadoop fs -text testtextsnappy.1475725399538/part-00001.snappy
      
      (snip)
      
          Expected output:
          1	rafferty	31
          2	jones	33
          3	steinberg	33
          Actual output:
      
      
      org.apache.bigtop.itest.hadoop.hdfs.TestTextSnappy > testTextSnappy FAILED
          org.junit.ComparisonFailure: Incorrect output expected:<[]> but was:<[1	rafferty	31
          2	jones	33
          3	steinberg	33]>
              at org.junit.Assert.assertEquals(Assert.java:115)
      
      (snip)
      

      "Expected" and "actual" outputs were swapped between the above two messages.

        Activity

        Hide
        sekikn Kengo Seki added a comment -

        Attaching a patch. I grepped bigtop-tests by assertEquals and fixed the same issues I found.

        Show
        sekikn Kengo Seki added a comment - Attaching a patch. I grepped bigtop-tests by assertEquals and fixed the same issues I found.
        Hide
        cos Konstantin Boudnik added a comment -

        Seems to be in order by looking at it. Committing.

        Show
        cos Konstantin Boudnik added a comment - Seems to be in order by looking at it. Committing.
        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master. Thanks Kengo Seki!

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master. Thanks Kengo Seki !

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            sekikn Kengo Seki
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development