Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2523

Incorrect cycle dependency during puppet deployment causes error at Debian 8

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment
    • Labels:
      None

      Description

      This issue appears on Debian 8.4 with puppet 3.7.2
      Upgrading puppet up to 3.8.4 from backports repo resolves this issue


      puppetize.sh script should be modified so debian backports repo will used to install puppet

      http://mail-archives.apache.org/mod_mbox/bigtop-user/201512.mbox/%3CDC4CEA66-273C-4ABA-A994-6F29AB79DE3E@gmx.de%3E

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kirill-morozov-epam opened a pull request:

          https://github.com/apache/bigtop/pull/141

          BIGTOP-2523. in order to install puppet 3.8 we need to get it from pu…

          …ppet repo
          https://issues.apache.org/jira/browse/BIGTOP-2523
          Incorrect cycle dependency during puppet deployment causes error at Debian 8

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/141.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #141


          commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2
          Author: Artur Papikyan <artur_papikyan@epam.com>
          Date: 2016-08-26T13:12:42Z

          BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kirill-morozov-epam opened a pull request: https://github.com/apache/bigtop/pull/141 BIGTOP-2523 . in order to install puppet 3.8 we need to get it from pu… …ppet repo https://issues.apache.org/jira/browse/BIGTOP-2523 Incorrect cycle dependency during puppet deployment causes error at Debian 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2 Author: Artur Papikyan <artur_papikyan@epam.com> Date: 2016-08-26T13:12:42Z BIGTOP-2523 . in order to install puppet 3.8 we need to get it from puppet repo
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam closed the pull request at:

          https://github.com/apache/bigtop/pull/141

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam closed the pull request at: https://github.com/apache/bigtop/pull/141
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kirill-morozov-epam reopened a pull request:

          https://github.com/apache/bigtop/pull/141

          BIGTOP-2523. in order to install puppet 3.8 we need to get it from pu…

          …ppet repo
          https://issues.apache.org/jira/browse/BIGTOP-2523
          Incorrect cycle dependency during puppet deployment causes error at Debian 8

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/141.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #141


          commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2
          Author: Artur Papikyan <artur_papikyan@epam.com>
          Date: 2016-08-26T13:12:42Z

          BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kirill-morozov-epam reopened a pull request: https://github.com/apache/bigtop/pull/141 BIGTOP-2523 . in order to install puppet 3.8 we need to get it from pu… …ppet repo https://issues.apache.org/jira/browse/BIGTOP-2523 Incorrect cycle dependency during puppet deployment causes error at Debian 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2 Author: Artur Papikyan <artur_papikyan@epam.com> Date: 2016-08-26T13:12:42Z BIGTOP-2523 . in order to install puppet 3.8 we need to get it from puppet repo
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user c0s commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/141#discussion_r76845555

          — Diff: bigtop_toolchain/bin/puppetize.sh —
          @@ -54,8 +54,13 @@ case $

          {ID}

          -$

          {VERSION_ID}

          in
          apt-get -y install curl sudo unzip wget puppet software-properties-common
          ;;
          debian-8*)
          + apt-get update
          + apt-get -y install wget
          + # BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo
          + wget -O /tmp/puppetlabs-release-trusty.deb https://apt.puppetlabs.com/puppetlabs-release-trusty.deb && dpkg -i /tmp/puppetlabs-release-trusty.deb
          + rm -f /tmp/puppetlabs-release-trusty.deb
          apt-get update

          • apt-get -y install curl sudo unzip wget puppet
            + apt-get -y install curl sudo unzip puppet
              • End diff –

          this looks like a formatting change, irrelevant to the scope

          Show
          githubbot ASF GitHub Bot added a comment - Github user c0s commented on a diff in the pull request: https://github.com/apache/bigtop/pull/141#discussion_r76845555 — Diff: bigtop_toolchain/bin/puppetize.sh — @@ -54,8 +54,13 @@ case $ {ID} -$ {VERSION_ID} in apt-get -y install curl sudo unzip wget puppet software-properties-common ;; debian-8*) + apt-get update + apt-get -y install wget + # BIGTOP-2523 . in order to install puppet 3.8 we need to get it from puppet repo + wget -O /tmp/puppetlabs-release-trusty.deb https://apt.puppetlabs.com/puppetlabs-release-trusty.deb && dpkg -i /tmp/puppetlabs-release-trusty.deb + rm -f /tmp/puppetlabs-release-trusty.deb apt-get update apt-get -y install curl sudo unzip wget puppet + apt-get -y install curl sudo unzip puppet End diff – this looks like a formatting change, irrelevant to the scope
          Hide
          cos Konstantin Boudnik added a comment -

          It seems reasonable to me, but perhaps Olaf Flebbe can take a look as he was the master mind behind this concept?

          Show
          cos Konstantin Boudnik added a comment - It seems reasonable to me, but perhaps Olaf Flebbe can take a look as he was the master mind behind this concept?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rvs commented on the issue:

          https://github.com/apache/bigtop/pull/141

          LGTM! (aside from the formatting fix). Olaf taking a look would be great, but I think it is small enough so we can just go ahead and commit it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rvs commented on the issue: https://github.com/apache/bigtop/pull/141 LGTM! (aside from the formatting fix). Olaf taking a look would be great, but I think it is small enough so we can just go ahead and commit it.
          Hide
          oflebbe Olaf Flebbe added a comment -

          I never had the issue mentioned above. No time to look into it right now.
          But if it is fixed by updating to puppetlabs puppet 3.8, its fine by me.

          The patch itself looks fine.
          So: +1 from me.

          Show
          oflebbe Olaf Flebbe added a comment - I never had the issue mentioned above. No time to look into it right now. But if it is fixed by updating to puppetlabs puppet 3.8, its fine by me. The patch itself looks fine. So: +1 from me.
          Hide
          cos Konstantin Boudnik added a comment -

          Kirill Morozov, please update the patch with fixed formatting and I will commit the patch after that.

          Show
          cos Konstantin Boudnik added a comment - Kirill Morozov , please update the patch with fixed formatting and I will commit the patch after that.
          Hide
          kirill-morozov-epam Kirill Morozov added a comment -

          Formatting fixed

          Show
          kirill-morozov-epam Kirill Morozov added a comment - Formatting fixed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user c0s commented on the issue:

          https://github.com/apache/bigtop/pull/141

          I am confused. Who's the author of the patch? The commit shows
          ```
          From: Artur Papikyan <artur_papikyan@epam.com>
          Date: Fri, 26 Aug 2016 16:12:42 +0300
          ```
          Is this correct?

          Show
          githubbot ASF GitHub Bot added a comment - Github user c0s commented on the issue: https://github.com/apache/bigtop/pull/141 I am confused. Who's the author of the patch? The commit shows ``` From: Artur Papikyan <artur_papikyan@epam.com> Date: Fri, 26 Aug 2016 16:12:42 +0300 ``` Is this correct?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam commented on the issue:

          https://github.com/apache/bigtop/pull/141

          This is correct. Artur the author of the patch

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam commented on the issue: https://github.com/apache/bigtop/pull/141 This is correct. Artur the author of the patch
          Hide
          cos Konstantin Boudnik added a comment -

          Committed and pushed to the master branch. Thanks for your contribution, Artur A. Papikyan!

          Show
          cos Konstantin Boudnik added a comment - Committed and pushed to the master branch. Thanks for your contribution, Artur A. Papikyan !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user c0s commented on the issue:

          https://github.com/apache/bigtop/pull/141

          I have committed the fix. Thanks for your help guys, please close the PR as you see fit.

          Show
          githubbot ASF GitHub Bot added a comment - Github user c0s commented on the issue: https://github.com/apache/bigtop/pull/141 I have committed the fix. Thanks for your help guys, please close the PR as you see fit.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam closed the pull request at:

          https://github.com/apache/bigtop/pull/141

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam closed the pull request at: https://github.com/apache/bigtop/pull/141

            People

            • Assignee:
              fiGarick Artur A. Papikyan
              Reporter:
              kirill-morozov-epam Kirill Morozov
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development