Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2521

Problem with deprecated methods in puppet code with puppet option parser=future

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment
    • Labels:
      None

      Description

      With the Puppet 4 on the horizon, some of the existing functionality will be failing. Let's prepare for this

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kirill-morozov-epam opened a pull request:

          https://github.com/apache/bigtop/pull/142

          BIGTOP-2521: Problem with deprecated methods in puppet code with puppet option parser=future

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2521

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/142.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #142


          commit af239887b4f81026cad4adcea7d826222741600b
          Author: Kirill Morozov <kirill_morozov@epam.ru>
          Date: 2016-08-26T10:01:51Z

          BIGTOP-2521: code fixed according require parser=future


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kirill-morozov-epam opened a pull request: https://github.com/apache/bigtop/pull/142 BIGTOP-2521 : Problem with deprecated methods in puppet code with puppet option parser=future You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2521 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit af239887b4f81026cad4adcea7d826222741600b Author: Kirill Morozov <kirill_morozov@epam.ru> Date: 2016-08-26T10:01:51Z BIGTOP-2521 : code fixed according require parser=future
          Hide
          rvs Roman Shaposhnik added a comment -

          Kirill Morozov quick question: are these changes incompatible with the older Puppet that we're still using?

          Show
          rvs Roman Shaposhnik added a comment - Kirill Morozov quick question: are these changes incompatible with the older Puppet that we're still using?
          Hide
          kirill-morozov-epam Kirill Morozov added a comment -

          Roman, these changes compatible with Puppet 3.8.x

          Show
          kirill-morozov-epam Kirill Morozov added a comment - Roman, these changes compatible with Puppet 3.8.x
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user c0s commented on the issue:

          https://github.com/apache/bigtop/pull/142

          The changes look good, but I feel they will break the BIGTOP-2524 patch and it'd needed to get rebased. I will be pushing this one shortly unless I hear otherwise.

          Show
          githubbot ASF GitHub Bot added a comment - Github user c0s commented on the issue: https://github.com/apache/bigtop/pull/142 The changes look good, but I feel they will break the BIGTOP-2524 patch and it'd needed to get rebased. I will be pushing this one shortly unless I hear otherwise.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user c0s commented on the issue:

          https://github.com/apache/bigtop/pull/142

          Committed, please close the PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user c0s commented on the issue: https://github.com/apache/bigtop/pull/142 Committed, please close the PR
          Hide
          cos Konstantin Boudnik added a comment -

          Committed to the master. Thank you Kirill Morozov!

          Show
          cos Konstantin Boudnik added a comment - Committed to the master. Thank you Kirill Morozov !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam closed the pull request at:

          https://github.com/apache/bigtop/pull/142

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam closed the pull request at: https://github.com/apache/bigtop/pull/142

            People

            • Assignee:
              kirill-morozov-epam Kirill Morozov
              Reporter:
              kirill-morozov-epam Kirill Morozov
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development