Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment
    • Labels:

      Description

      I'm creating this ticket to track the work that I'm doing to make a Zookeeper Juju Charm.

      Work In Progress code here (feel free to comment on the PR): https://github.com/juju-solutions/bigtop/pull/8

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment -

          Kevin W Monroe, Cory Johns, Konstantinos Tsakalozos - would be nice if charm-knowledgeable individuals can review and provide feedback Thanks!

          Show
          cos Konstantin Boudnik added a comment - Kevin W Monroe , Cory Johns , Konstantinos Tsakalozos - would be nice if charm-knowledgeable individuals can review and provide feedback Thanks!
          Hide
          ktsakalozos Konstantinos Tsakalozos added a comment -

          Thank you for your work Pete.

          It is a +1 from me since this charm has gone two rounds of internal review before creating this ticket.

          Pete, there is one thing that needs your attention so that this can be considered mergable. Could you please squash the commit messages into a single message that looks like this "BIGTOP-2476: Add Zookeeper Charm". Konstantin Boudnik or any other more senior member of the project could verify that the above commit message format is correct.

          Show
          ktsakalozos Konstantinos Tsakalozos added a comment - Thank you for your work Pete. It is a +1 from me since this charm has gone two rounds of internal review before creating this ticket. Pete, there is one thing that needs your attention so that this can be considered mergable. Could you please squash the commit messages into a single message that looks like this " BIGTOP-2476 : Add Zookeeper Charm". Konstantin Boudnik or any other more senior member of the project could verify that the above commit message format is correct.
          Hide
          petevg Pete Vander Giessen added a comment -

          Konstantinos Tsakalozos: Yep. I created the linked PR when we were planning on bundling the Zookeeper charm with everything else that got accepted. I'm going to create a properly named and squashed PR today.

          Show
          petevg Pete Vander Giessen added a comment - Konstantinos Tsakalozos : Yep. I created the linked PR when we were planning on bundling the Zookeeper charm with everything else that got accepted. I'm going to create a properly named and squashed PR today.
          Hide
          cos Konstantin Boudnik added a comment -

          I guess we do BIGTOP-####: JIRA title according to the wiki, but strangely enough I was always using '.' as a separator as it looked less crowded to me Thanks!

          Show
          cos Konstantin Boudnik added a comment - I guess we do BIGTOP-####: JIRA title according to the wiki , but strangely enough I was always using '.' as a separator as it looked less crowded to me Thanks!
          Hide
          petevg Pete Vander Giessen added a comment -

          Quick update: I'm going to hold off on making a formal/properly formatted PR for this. Per a discussion w/ the Canonical Big Data team, we're going to require that our charms have a smoke test action going forward. My Zookeeper charm does smoke test-ish things in the amulet tests, but it lacks the explicit smoke test action.

          Ideally, the smoke test action would simply run the smoke tests for a given module in Bigtop. It looks like Zookeeper does not currently have any smoke tests associated with it, however. I'm going to open a separate ticket to track the work of making a smoke test.

          Show
          petevg Pete Vander Giessen added a comment - Quick update: I'm going to hold off on making a formal/properly formatted PR for this. Per a discussion w/ the Canonical Big Data team, we're going to require that our charms have a smoke test action going forward. My Zookeeper charm does smoke test-ish things in the amulet tests, but it lacks the explicit smoke test action. Ideally, the smoke test action would simply run the smoke tests for a given module in Bigtop. It looks like Zookeeper does not currently have any smoke tests associated with it, however. I'm going to open a separate ticket to track the work of making a smoke test.
          Hide
          cos Konstantin Boudnik added a comment -

          Having a smoke test as a part of the charm is a great idea. I don't think it makes much sense splitting the work in two JIRAs, unless you see this as a more convenient way of delivering the functionality.

          Show
          cos Konstantin Boudnik added a comment - Having a smoke test as a part of the charm is a great idea. I don't think it makes much sense splitting the work in two JIRAs, unless you see this as a more convenient way of delivering the functionality.
          Hide
          petevg Pete Vander Giessen added a comment -

          Keeping it as a single Jira would be fine with me. I'll go ahead and mark the ticket I created as a duplicate, and track all the work here.

          Show
          petevg Pete Vander Giessen added a comment - Keeping it as a single Jira would be fine with me. I'll go ahead and mark the ticket I created as a duplicate, and track all the work here.
          Hide
          cos Konstantin Boudnik added a comment -

          Sorry, I was confused, but now I can see. When you're talking about the smoke test I didn't immediately make a connection to the smoke tests suite we have in the project. Only after writing the comment I realized that the smoke test would be a different thing from the charm itself. If this is true, please do the test work separately from the charm itself - it makes all the sense. Sorry again

          Show
          cos Konstantin Boudnik added a comment - Sorry, I was confused, but now I can see. When you're talking about the smoke test I didn't immediately make a connection to the smoke tests suite we have in the project. Only after writing the comment I realized that the smoke test would be a different thing from the charm itself. If this is true, please do the test work separately from the charm itself - it makes all the sense. Sorry again
          Hide
          petevg Pete Vander Giessen added a comment -

          No worries. Ticket reopened, and I will submit things as two separate PRs, as originally planned

          Show
          petevg Pete Vander Giessen added a comment - No worries. Ticket reopened, and I will submit things as two separate PRs, as originally planned
          Hide
          rvs Roman Shaposhnik added a comment -

          Super excited about this! And thanks a million to Pete Vander Giessen for doing the right thing and pursuing smoke tests as well! Btw, I presume the smoke tests will be done as regular Bigtop smokes, so that we can use them outside of Charms context as well, correct?

          Show
          rvs Roman Shaposhnik added a comment - Super excited about this! And thanks a million to Pete Vander Giessen for doing the right thing and pursuing smoke tests as well! Btw, I presume the smoke tests will be done as regular Bigtop smokes, so that we can use them outside of Charms context as well, correct?
          Hide
          petevg Pete Vander Giessen added a comment -

          Roman Shaposhnik: Correct. When I'm done with it, the charm will just invoke whatever Bigtop smoke tests that exist, and I'll have added at least basic smoke tests in Bigtop's smoke tests dir.

          Show
          petevg Pete Vander Giessen added a comment - Roman Shaposhnik : Correct. When I'm done with it, the charm will just invoke whatever Bigtop smoke tests that exist, and I'll have added at least basic smoke tests in Bigtop's smoke tests dir.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user petevg opened a pull request:

          https://github.com/apache/bigtop/pull/129

          BIGTOP-2476 Add Zookeeper Charm

          Based on the vanilla apache-zookeeper charm, but utlizes Bigtop to
          reduce complexity in the charm itself.

          This covers all the changes that we discussed, including requiring a manual rolling restart after adding or removing zk peers (per http://www.benhallbenhall.com/2011/07/rolling-restart-in-apache-zookeeper-to-dynamically-add-servers-to-the-ensemble/)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/juju-solutions/bigtop BIGTOP-2476-zookeeper

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/129.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #129


          commit d3ddbf8c95850ca08f9a0b039d7c89b18bdb4507
          Author: Pete Vander Giessen <petevg@gmail.com>
          Date: 2016-06-06T14:46:48Z

          BIGTOP-2476 Add Zookeeper Charm

          Based on the vanilla apache-zookeeper charm, but utlizes Bigtop to
          reduce complexity in the charm itself.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user petevg opened a pull request: https://github.com/apache/bigtop/pull/129 BIGTOP-2476 Add Zookeeper Charm Based on the vanilla apache-zookeeper charm, but utlizes Bigtop to reduce complexity in the charm itself. This covers all the changes that we discussed, including requiring a manual rolling restart after adding or removing zk peers (per http://www.benhallbenhall.com/2011/07/rolling-restart-in-apache-zookeeper-to-dynamically-add-servers-to-the-ensemble/ ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/juju-solutions/bigtop BIGTOP-2476 -zookeeper Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit d3ddbf8c95850ca08f9a0b039d7c89b18bdb4507 Author: Pete Vander Giessen <petevg@gmail.com> Date: 2016-06-06T14:46:48Z BIGTOP-2476 Add Zookeeper Charm Based on the vanilla apache-zookeeper charm, but utlizes Bigtop to reduce complexity in the charm itself.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kwmonroe commented on the issue:

          https://github.com/apache/bigtop/pull/129

          LGTM, verified deployment and smoke tests on azure and aws.

          Show
          githubbot ASF GitHub Bot added a comment - Github user kwmonroe commented on the issue: https://github.com/apache/bigtop/pull/129 LGTM, verified deployment and smoke tests on azure and aws.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/129

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/129
          Hide
          kwmonroe Kevin W Monroe added a comment -

          Charm built from this source is available at:

          https://jujucharms.com/zookeeper/

          Show
          kwmonroe Kevin W Monroe added a comment - Charm built from this source is available at: https://jujucharms.com/zookeeper/

            People

            • Assignee:
              petevg Pete Vander Giessen
              Reporter:
              petevg Pete Vander Giessen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Development