Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      The optimazation within build.gradle to create a /usr/share/gradle.home directory does not fully work.

      At each time the file
      https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/apache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.jar
      is downloaded.

      Propose to remove all this code alltogether and substitute it with a more docker-ish approach:

      Generate a clean container with the toolchain. Start it running ./gradlew within. Commit it as bigtop/slaves:trunk-os

      A local prototype looked very promising and decreased startup time.

      1. BIGTOP-2474.patch
        11 kB
        Olaf Flebbe
      2. BIGTOP-2474.2.patch
        11 kB
        Olaf Flebbe

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Please review or comment

          Show
          oflebbe Olaf Flebbe added a comment - Please review or comment
          Hide
          cos Konstantin Boudnik added a comment -

          It does make a lot of sense, really. I guess the current approach was a way to shift the startup time in the deployment and build of each package to, at least, once during the image creation. And it worked to some extent. But I like your approach more!

          Show
          cos Konstantin Boudnik added a comment - It does make a lot of sense, really. I guess the current approach was a way to shift the startup time in the deployment and build of each package to, at least, once during the image creation. And it worked to some extent. But I like your approach more!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Found a way to run ./gradlew from within the Dockerfile itself.

          The patch is so much cleaner now. I really like it

          Show
          oflebbe Olaf Flebbe added a comment - Found a way to run ./gradlew from within the Dockerfile itself. The patch is so much cleaner now. I really like it
          Hide
          cos Konstantin Boudnik added a comment -

          If you do something like this
          RUN (cd /tmp/bigtop && ./gradlew) && rm -rf /tmp/bigtop

          you can cut off one extra 'cd'

          But I like it too, please commit!

          Show
          cos Konstantin Boudnik added a comment - If you do something like this RUN (cd /tmp/bigtop && ./gradlew) && rm -rf /tmp/bigtop you can cut off one extra 'cd' But I like it too, please commit!
          Hide
          oflebbe Olaf Flebbe added a comment -

          You are right! But since I am lazy I leave it as it is.

          Thanx

          Show
          oflebbe Olaf Flebbe added a comment - You are right! But since I am lazy I leave it as it is. Thanx
          Hide
          oflebbe Olaf Flebbe added a comment -

          committed.

          Show
          oflebbe Olaf Flebbe added a comment - committed.

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development